From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, tgolembi@redhat.com,
mdroth@linux.vnet.ibm.com
Subject: Re: [PATCH 1/4] qga: Rename guest-get-devices return member 'address' to 'id'
Date: Wed, 21 Oct 2020 09:34:35 +0200 [thread overview]
Message-ID: <0f29af6e-e134-4ccd-1946-5ababf40eab8@redhat.com> (raw)
In-Reply-To: <20201021071520.2168877-2-armbru@redhat.com>
On 10/21/20 9:15 AM, Markus Armbruster wrote:
> Member 'address' is union GuestDeviceAddress with a single branch
> GuestDeviceAddressPCI, containing PCI vendor ID and device ID. This
> is not a PCI address. Type GuestPCIAddress is. Messed up in recent
> commit 2e4211cee4 "qga: add command guest-get-devices for reporting
> VirtIO devices".
Out of curiosity, how did you notice?
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> Rename type GuestDeviceAddressPCI to GuestDeviceIdPCI, type
> GuestDeviceAddress to GuestDeviceId, and member 'address' to 'id'.
>
> Document the member properly while there.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qga/qapi-schema.json | 17 +++++++++--------
> qga/commands-win32.c | 16 ++++++++--------
> 2 files changed, 17 insertions(+), 16 deletions(-)
next prev parent reply other threads:[~2020-10-21 7:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-21 7:15 [PATCH 0/4] qga: Fix several guest-get-devices issues Markus Armbruster
2020-10-21 7:15 ` [PATCH 1/4] qga: Rename guest-get-devices return member 'address' to 'id' Markus Armbruster
2020-10-21 7:34 ` Philippe Mathieu-Daudé [this message]
2020-10-21 8:08 ` Markus Armbruster
2020-10-21 7:46 ` Marc-André Lureau
2020-10-21 7:15 ` [PATCH 2/4] qga: Use common time encoding for guest-get-devices 'driver-date' Markus Armbruster
2020-10-21 7:42 ` Marc-André Lureau
2020-10-21 7:15 ` [PATCH 3/4] qga-win: Fix guest-get-devices error API violations Markus Armbruster
2020-10-21 7:37 ` Marc-André Lureau
2020-10-21 7:39 ` Philippe Mathieu-Daudé
2020-10-21 7:15 ` [PATCH 4/4] qga: Flatten simple union GuestDeviceId Markus Armbruster
2020-10-21 7:35 ` Philippe Mathieu-Daudé
2020-10-21 7:36 ` Marc-André Lureau
2020-10-27 6:35 ` [PATCH 0/4] qga: Fix several guest-get-devices issues Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f29af6e-e134-4ccd-1946-5ababf40eab8@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=tgolembi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).