From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"open list:Block layer core" <qemu-block@nongnu.org>
Subject: Re: [PATCH for-5.0? v3] qemu-img: Report convert errors by bytes, not sectors
Date: Fri, 3 Apr 2020 11:56:08 +0200 [thread overview]
Message-ID: <0f3c843f-1e68-7e5c-c623-1d42f82a7508@redhat.com> (raw)
In-Reply-To: <20200402135717.476398-1-eblake@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 750 bytes --]
On 02.04.20 15:57, Eric Blake wrote:
> Various qemu-img commands are inconsistent on whether they report
> status/errors in terms of bytes or sector offsets. The latter is
> confusing (especially as more places move to 4k block sizes), so let's
> switch everything to just use bytes everywhere. One iotest is
> impacted.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
>
> v3: Fix affected iotest [patchew]
>
> qemu-img.c | 8 ++++----
> tests/qemu-iotests/244.out | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
Thanks, applied to my block branch:
https://git.xanclic.moe/XanClic/qemu/commits/branch/block
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-04-03 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 13:57 [PATCH for-5.0? v3] qemu-img: Report convert errors by bytes, not sectors Eric Blake
2020-04-02 21:44 ` Philippe Mathieu-Daudé
2020-04-03 9:56 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f3c843f-1e68-7e5c-c623-1d42f82a7508@redhat.com \
--to=mreitz@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).