From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: ~ssinprem <ssinprem@celestica.com>, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org, srikanth@celestica.com, kgengan@celestica.com
Subject: Re: [PATCH qemu 1/2] hw/at24c : modify at24c to support 1 byte address mode
Date: Thu, 16 Feb 2023 09:25:02 +0100 [thread overview]
Message-ID: <0f69bfe5-3c49-c072-833c-24e19b91ad1b@linaro.org> (raw)
In-Reply-To: <167636845806.2107.2382940753543768501-1@git.sr.ht>
On 10/2/23 07:20, ~ssinprem wrote:
> From: Sittisak Sinprem <ssinprem@celestca.com>
>
> ---
> hw/nvram/eeprom_at24c.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/hw/nvram/eeprom_at24c.c b/hw/nvram/eeprom_at24c.c
> index 2d4d8b952f..693212b661 100644
> --- a/hw/nvram/eeprom_at24c.c
> +++ b/hw/nvram/eeprom_at24c.c
> @@ -87,7 +87,7 @@ uint8_t at24c_eeprom_recv(I2CSlave *s)
> EEPROMState *ee = AT24C_EE(s);
> uint8_t ret;
>
> - if (ee->haveaddr == 1) {
> + if (ee->rsize > 256 && ee->haveaddr == 1) {
> return 0xff;
> }
What represents this '256' magic value? Please add a definition.
next prev parent reply other threads:[~2023-02-16 8:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 9:54 [PATCH qemu 0/2] hw/at24c support eeprom size less than equal 256 byte ~ssinprem
2023-02-10 6:20 ` [PATCH qemu 1/2] hw/at24c : modify at24c to support 1 byte address mode ~ssinprem
2023-02-14 14:29 ` Cédric Le Goater
2023-02-15 20:39 ` Peter Delevoryas
2023-02-16 8:25 ` Philippe Mathieu-Daudé [this message]
2023-02-16 8:47 ` Sittisak Sinprem
2023-02-16 14:27 ` Sittisak Sinprem
2023-02-14 9:06 ` [PATCH qemu 2/2] aspeed/fuji : correct the eeprom size ~ssinprem
2023-02-14 14:28 ` Cédric Le Goater
2023-02-15 3:17 ` Sittisak Sinprem
2023-02-15 20:34 ` Peter Delevoryas
2023-02-16 14:23 ` Sittisak Sinprem
2023-02-16 18:43 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f69bfe5-3c49-c072-833c-24e19b91ad1b@linaro.org \
--to=philmd@linaro.org \
--cc=kgengan@celestica.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=srikanth@celestica.com \
--cc=ssinprem@celestica.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).