From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ADF6C4360C for ; Fri, 27 Sep 2019 17:15:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4156320872 for ; Fri, 27 Sep 2019 17:15:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4156320872 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDtpv-0005xg-8R for qemu-devel@archiver.kernel.org; Fri, 27 Sep 2019 13:15:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48431) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDtOj-0003uU-AV for qemu-devel@nongnu.org; Fri, 27 Sep 2019 12:47:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDtOh-0000Ij-3G for qemu-devel@nongnu.org; Fri, 27 Sep 2019 12:47:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48080) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iDtOb-0007rO-Ly; Fri, 27 Sep 2019 12:47:05 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2DF11898110; Fri, 27 Sep 2019 16:47:03 +0000 (UTC) Received: from [10.3.116.249] (ovpn-116-249.phx2.redhat.com [10.3.116.249]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8FFFE600CD; Fri, 27 Sep 2019 16:47:02 +0000 (UTC) Subject: Re: [PATCH 2/4] qemu-iotests: remove forceful execution success from library files To: Cleber Rosa , qemu-devel@nongnu.org References: <20190927141728.7137-1-crosa@redhat.com> <20190927141728.7137-3-crosa@redhat.com> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <0f7ccc53-9740-a689-ea5a-c86fe05d3d0f@redhat.com> Date: Fri, 27 Sep 2019 11:47:02 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20190927141728.7137-3-crosa@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.67]); Fri, 27 Sep 2019 16:47:03 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Michael Tokarev , Laurent Vivier , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/27/19 9:17 AM, Cleber Rosa wrote: > Should not be necessary on files that are not executed standalone. > > Signed-off-by: Cleber Rosa > --- > tests/qemu-iotests/common.config | 3 --- > tests/qemu-iotests/common.filter | 3 --- > tests/qemu-iotests/common.rc | 3 --- > 3 files changed, 9 deletions(-) > > diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iotests/common.config > index 6956d38d4c..0a24d960ff 100644 > --- a/tests/qemu-iotests/common.config > +++ b/tests/qemu-iotests/common.config > @@ -34,6 +34,3 @@ _optstr_add() > echo "$2" > fi > } > - > -# make sure this script returns success > -true The exit status of the source command in the caller depends on the last command executed here. However, you also have the point that if you delete this line, the last command executed is a function definition which is successful (for all 3 files touched). So there is no behavior change in dropping this line. Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org