From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Anthony PERARD <anthony.perard@citrix.com>,
qemu-devel@nongnu.org, qemu-block <qemu-block@nongnu.org>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Paul Durrant <paul@xen.org>,
xen-devel@lists.xenproject.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PATCH] xen-block: fix segv on unrealize
Date: Tue, 6 Jun 2023 15:44:08 +0200 [thread overview]
Message-ID: <0f7dd8c6-afa1-db05-f98c-7c5d35fd590a@linaro.org> (raw)
In-Reply-To: <20230606131605.55596-1-anthony.perard@citrix.com>
On 6/6/23 15:16, Anthony PERARD via wrote:
> From: Anthony PERARD <anthony.perard@citrix.com>
>
> Backtrace:
> qemu_lockcnt_lock (lockcnt=0xb4) at ../util/lockcnt.c:238
> aio_set_fd_handler (ctx=0x0, fd=51, is_external=true, io_read=0x0, io_write=0x0, io_poll=0x0, io_poll_ready=0x0, opaque=0x0) at ../util/aio-posix.c:119
> xen_device_unbind_event_channel (xendev=0x55c6da5b5000, channel=0x55c6da6c4c80, errp=0x7fff641ac608) at ../hw/xen/xen-bus.c:926
> xen_block_dataplane_stop (dataplane=0x55c6da6ddbe0) at ../hw/block/dataplane/xen-block.c:719
> xen_block_disconnect (xendev=0x55c6da5b5000, errp=0x0) at ../hw/block/xen-block.c:48
> xen_block_unrealize (xendev=0x55c6da5b5000) at ../hw/block/xen-block.c:154
> xen_device_unrealize (dev=0x55c6da5b5000) at ../hw/xen/xen-bus.c:956
> xen_device_exit (n=0x55c6da5b50d0, data=0x0) at ../hw/xen/xen-bus.c:985
> notifier_list_notify (list=0x55c6d91f9820 <exit_notifiers>, data=0x0) at ../util/notify.c:39
> qemu_run_exit_notifiers () at ../softmmu/runstate.c:760
>
> Fixes: f6eac904f682 ("xen-block: implement BlockDevOps->drained_begin()")
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> --
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/xen/xen-bus.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/xen/xen-bus.c b/hw/xen/xen-bus.c
> index 1e08cf027a..ece8ec40cd 100644
> --- a/hw/xen/xen-bus.c
> +++ b/hw/xen/xen-bus.c
> @@ -923,8 +923,10 @@ void xen_device_unbind_event_channel(XenDevice *xendev,
>
> QLIST_REMOVE(channel, list);
>
> - aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh),
> - NULL, NULL, NULL, NULL, NULL);
> + if (channel->ctx) {
> + aio_set_fd_handler(channel->ctx, qemu_xen_evtchn_fd(channel->xeh),
> + NULL, NULL, NULL, NULL, NULL);
> + }
>
> if (qemu_xen_evtchn_unbind(channel->xeh, channel->local_port) < 0) {
> error_setg_errno(errp, errno, "xenevtchn_unbind failed");
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
next prev parent reply other threads:[~2023-06-06 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 13:16 [PATCH] xen-block: fix segv on unrealize Anthony PERARD via
2023-06-06 13:44 ` Philippe Mathieu-Daudé [this message]
2023-06-06 14:10 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f7dd8c6-afa1-db05-f98c-7c5d35fd590a@linaro.org \
--to=philmd@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=kwolf@redhat.com \
--cc=paul@xen.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=stefanha@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).