From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Aleksandar Markovic <aleksandar.m.mail@gmail.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Igor Mammedov <imammedo@redhat.com>,
"richard.henderson@linaro.org" <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v27 06/21] target/rx: CPU definition
Date: Sat, 21 Dec 2019 17:55:06 +0100 [thread overview]
Message-ID: <0f822bed-dfbc-b4d2-c88f-f61bf5f16bfa@redhat.com> (raw)
In-Reply-To: <CAL1e-=iFV=PumJ2M=rcpntkJ3NFWT7sqMcroJmiLYhsibwFf4Q@mail.gmail.com>
On 12/21/19 5:03 PM, Aleksandar Markovic wrote:
>
>
> On Saturday, December 21, 2019, Yoshinori Sato
> <ysato@users.sourceforge.jp <mailto:ysato@users.sourceforge.jp>> wrote:
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp
> <mailto:ysato@users.sourceforge.jp>>
>
> Message-Id: <20190616142836.10614-4-ysato@users.sourceforge.jp
> <mailto:20190616142836.10614-4-ysato@users.sourceforge.jp>>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org
> <mailto:richard.henderson@linaro.org>>
> Message-Id: <20190607091116.49044-4-ysato@users.sourceforge.jp
> <mailto:20190607091116.49044-4-ysato@users.sourceforge.jp>>
>
>
> Hi, Yoshinori,
>
> I noticed you have a lot of line like this
>
> Message-Id: <20190607091116.49044-9-ysato@users.sourceforge.jp
> <mailto:20190607091116.49044-9-ysato@users.sourceforge.jp>>
>
> ... sometimes even several in the same message.
>
> May I ask you to delete *all* such lines from commit messages, and
> resend the series?
I expected this series to be ready for merge, and asked Richard if he
could do that to avoid a respin of new version, but apparently Yoshinori
missed my comment:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg664071.html
>
> Also, I don't see the documentation update for the new target. Please
> provide dome appropriate content in qemu-doc.texi (
> https://github.com/qemu/qemu/blob/master/qemu-doc.texi ), and include it
> in the next version.
>
> Best regards,
>
> Aleksandar
next prev parent reply other threads:[~2019-12-21 16:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-21 14:42 [PATCH v27 00/21] Add RX archtecture support Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 01/21] MAINTAINERS: Add RX Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 02/21] qemu/bitops.h: Add extract8 and extract16 Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 03/21] hw/registerfields.h: Add 8bit and 16bit register macros Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 04/21] target/rx: TCG translation Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 05/21] target/rx: TCG helper Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 06/21] target/rx: CPU definition Yoshinori Sato
2019-12-21 16:03 ` Aleksandar Markovic
2019-12-21 16:55 ` Philippe Mathieu-Daudé [this message]
2019-12-22 15:34 ` Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 07/21] target/rx: RX disassembler Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 08/21] target/rx: Disassemble rx_index_addr into a string Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 09/21] target/rx: Replace operand with prt_ldmi in disassembler Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 10/21] target/rx: Use prt_ldmi for XCHG_mr disassembly Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 11/21] target/rx: Emit all disassembly in one prt() Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 12/21] target/rx: Collect all bytes during disassembly Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 13/21] target/rx: Dump bytes for each insn " Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 14/21] hw/intc: RX62N interrupt controller (ICUa) Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 15/21] hw/timer: RX62N internal timer modules Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 16/21] hw/char: RX62N serial communication interface (SCI) Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 17/21] hw/rx: RX Target hardware definition Yoshinori Sato
2019-12-26 9:41 ` Aleksandar Markovic
2019-12-21 14:42 ` [PATCH v27 18/21] hw/rx: Honor -accel qtest Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 19/21] hw/rx: Restrict the RX62N microcontroller to the RX62N CPU core Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 20/21] Add rx-softmmu Yoshinori Sato
2019-12-21 14:42 ` [PATCH v27 21/21] BootLinuxConsoleTest: Test the RX-Virt machine Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f822bed-dfbc-b4d2-c88f-f61bf5f16bfa@redhat.com \
--to=philmd@redhat.com \
--cc=aleksandar.m.mail@gmail.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).