From: Richard Henderson <richard.henderson@linaro.org>
To: Taylor Simpson <tsimpson@quicinc.com>, qemu-devel@nongnu.org
Cc: philmd@linaro.org, ale@rev.ng, anjo@rev.ng, bcain@quicinc.com,
quic_mathbern@quicinc.com
Subject: Re: [PATCH 21/21] Hexagon (target/hexagon) Move items to DisasContext
Date: Thu, 27 Apr 2023 12:15:53 +0100 [thread overview]
Message-ID: <0f86e891-8309-e799-be4e-62bd0de7983d@linaro.org> (raw)
In-Reply-To: <20230426004240.1319494-2-tsimpson@quicinc.com>
On 4/26/23 01:42, Taylor Simpson wrote:
> The following items in the CPUHexagonState are only used for bookkeeping
> within the translation of a packet. With recent changes that eliminate
> the need to free TCGv variables, these make more sense to be transient
> and kept in DisasContext.
>
> The following items are moved
> dczero_addr
> branch_taken
> this_PC
>
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> ---
> target/hexagon/cpu.h | 3 ---
> target/hexagon/helper.h | 2 +-
> target/hexagon/macros.h | 6 +++++-
> target/hexagon/translate.h | 5 ++---
> target/hexagon/genptr.c | 6 +++---
> target/hexagon/op_helper.c | 5 ++---
> target/hexagon/translate.c | 23 +++++++----------------
> target/hexagon/README | 2 +-
> 8 files changed, 21 insertions(+), 31 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-04-27 11:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 0:42 [PATCH 20/21] Hexagon (target/hexagon) Move pkt_has_store_s1 to DisasContext Taylor Simpson
2023-04-26 0:42 ` [PATCH 21/21] Hexagon (target/hexagon) Move items " Taylor Simpson
2023-04-27 11:15 ` Richard Henderson [this message]
2023-04-27 11:11 ` [PATCH 20/21] Hexagon (target/hexagon) Move pkt_has_store_s1 " Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f86e891-8309-e799-be4e-62bd0de7983d@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ale@rev.ng \
--cc=anjo@rev.ng \
--cc=bcain@quicinc.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_mathbern@quicinc.com \
--cc=tsimpson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).