From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1enoYd-0000kA-Kk for qemu-devel@nongnu.org; Mon, 19 Feb 2018 11:44:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1enoYc-0003ur-Ho for qemu-devel@nongnu.org; Mon, 19 Feb 2018 11:44:51 -0500 References: <20180219145459.8143-1-berto@igalia.com> From: Eric Blake Message-ID: <0fb270ca-5aae-0db3-93c2-43ebd6162027@redhat.com> Date: Mon, 19 Feb 2018 10:44:23 -0600 MIME-Version: 1.0 In-Reply-To: <20180219145459.8143-1-berto@igalia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] docs: document how to use the l2-cache-entry-size parameter List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , "Denis V . Lunev" , qemu-block@nongnu.org, Max Reitz On 02/19/2018 08:54 AM, Alberto Garcia wrote: > This patch updates docs/qcow2-cache.txt explaining how to use the new > l2-cache-entry-size parameter. > > Here's a more detailed technical description of this feature: > > https://lists.gnu.org/archive/html/qemu-block/2017-09/msg00635.html > > And here are some performance numbers: > > https://lists.gnu.org/archive/html/qemu-block/2017-12/msg00507.html > > Signed-off-by: Alberto Garcia > --- > docs/qcow2-cache.txt | 46 +++++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 43 insertions(+), 3 deletions(-) > > +Some things to take into account: > + > + - The L2 cache entry size has the same restrictions as the cluster > + size (power of two, at least 512 bytes). Worth mentioning the upper limit of the cluster size? Otherwise, Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org