From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 575B5C433F5 for ; Thu, 28 Oct 2021 00:55:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC14860F6F for ; Thu, 28 Oct 2021 00:54:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DC14860F6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:50434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mfth4-0008Bl-J1 for qemu-devel@archiver.kernel.org; Wed, 27 Oct 2021 20:54:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42624) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mfted-0006pV-LN for qemu-devel@nongnu.org; Wed, 27 Oct 2021 20:52:27 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]:52115) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mfteZ-0000eU-M5 for qemu-devel@nongnu.org; Wed, 27 Oct 2021 20:52:25 -0400 Received: by mail-pj1-x1032.google.com with SMTP id in13so1029493pjb.1 for ; Wed, 27 Oct 2021 17:52:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sMi7gLggzWQvoWoUXCe8YtKjg0XCU9cdeyqmkMf1mak=; b=AgMYR9jFzT/yMzL5w0sDZH86/AX22/RgXZvDcclHkBk8ZR3V62wARWux9OdLRR9znK 3aNnPQEqJv4oldOsTQzWOZsitGcwtSx5qUusJp0fQnzApaOc6+aPeNnBC2A/aA4Qk6fw lggYUrXfj+IaMF4jiUMlIBhaeeT+YZYt79wmTjA4dwj1VfyIsZL4d/bT9V9/nb6fIhbw ZBcEART/8AEBvzCSxb2rrXYM5ymug2HPuomP+w1+njRnQ3KwSaW093nSKQoWI+kiWMSR Bh/W9vSFJ11YNyDpwAPvm+yKzgtBu6ZO3UCQgLWt0U4vmECSMn2Pjpjc/BtlQzYnUzro fG7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sMi7gLggzWQvoWoUXCe8YtKjg0XCU9cdeyqmkMf1mak=; b=Tt2XroK0rJMQXN5nd6SWD3qWJgA5Qm+7ez3WFw1MPqJenttrjVZXc8dHF45t6neB7p ELeDOC8BtO9ctGJ1PFlpSi+H3WgRjP74xL3xUIMdhxM+jEAauGt42jAOVJN+JcPG7vME 2deUZspzFDnvtg05Vl7uXNhemsz/r8SeQYC2FziC6kjGEm6pWe33ztBas8bUk6+g65hY M9gdFROHqMOES3wRkGXu1zu0yX2gNYWB8UaXaDTg43NWE+VFH6KGMoRcCjICS1cR7xdl lY+zM244BVVZETlUn3/AbrU/dIrtKqlb6Qal5cZlGuKS17Zvdrub580VIzSSe3D6f1Zo b+mA== X-Gm-Message-State: AOAM533vjrT1XrvZWOjUHhEMHwuqz6bzCIPizPtAxioU9EGQhq4uwrbS op+R6tjrTRQ9WzC1fRkEUNWoyw== X-Google-Smtp-Source: ABdhPJzFC/rMaJ3CH21SHfeGgSp7G9hzYayF+hCI63b1QzDDXzTlN4ycKOwqPs0r5aSt4irnP6lnWQ== X-Received: by 2002:a17:90b:4ac9:: with SMTP id mh9mr9449914pjb.173.1635382339708; Wed, 27 Oct 2021 17:52:19 -0700 (PDT) Received: from [192.168.1.11] ([71.212.134.125]) by smtp.gmail.com with ESMTPSA id k19sm1109591pff.195.2021.10.27.17.52.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Oct 2021 17:52:19 -0700 (PDT) Subject: Re: [PATCH v3 11/18] hw/intc/sh_intc: Drop another useless macro To: BALATON Zoltan , qemu-devel@nongnu.org References: From: Richard Henderson Message-ID: <0fb45ace-575e-8b8e-b0e5-1e681e110c7e@linaro.org> Date: Wed, 27 Oct 2021 17:52:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x1032.google.com X-Spam_score_int: -48 X-Spam_score: -4.9 X-Spam_bar: ---- X-Spam_report: (-4.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-2.847, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Magnus Damm , Yoshinori Sato Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/27/21 2:54 PM, BALATON Zoltan wrote: > The INT_REG_PARAMS macro was only used a few times within one function > on adjacent lines and is actually more complex than writing out the > parameters so simplify it by expanding the macro at call sites and > dropping the #define. > > Signed-off-by: BALATON Zoltan > Reviewed-by: Philippe Mathieu-Daudé > --- > hw/intc/sh_intc.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) Reviewed-by: Richard Henderson r~