From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emj81-00075s-Sx for qemu-devel@nongnu.org; Fri, 16 Feb 2018 11:44:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emj7y-0004tU-PB for qemu-devel@nongnu.org; Fri, 16 Feb 2018 11:44:53 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44220 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1emj7y-0004t5-JW for qemu-devel@nongnu.org; Fri, 16 Feb 2018 11:44:50 -0500 Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w1GGimqI100425 for ; Fri, 16 Feb 2018 11:44:49 -0500 Received: from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203]) by mx0a-001b2d01.pphosted.com with ESMTP id 2g603bfwwb-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 16 Feb 2018 11:44:48 -0500 Received: from localhost by e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 16 Feb 2018 11:44:45 -0500 References: <1518735273-16089-1-git-send-email-walling@linux.vnet.ibm.com> <1518735273-16089-7-git-send-email-walling@linux.vnet.ibm.com> <4ff97ab0-d848-05a4-9ac2-344bd67e73ef@redhat.com> <10e144ef-cc5d-8958-adf1-03cc4ef13580@linux.vnet.ibm.com> From: "Collin L. Walling" Date: Fri, 16 Feb 2018 11:44:42 -0500 MIME-Version: 1.0 In-Reply-To: <10e144ef-cc5d-8958-adf1-03cc4ef13580@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Message-Id: <0fbc3022-dc3f-7dbc-10e4-d7d75ff9742e@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v6 06/12] s390-ccw: parse and set boot menu options List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Viktor Mihajlovski , Thomas Huth , qemu-s390x@nongnu.org, qemu-devel@nongnu.org Cc: frankja@linux.vnet.ibm.com, cohuck@redhat.com, david@redhat.com, alifm@linux.vnet.ibm.com, borntraeger@de.ibm.com, eblake@redhat.com On 02/16/2018 11:36 AM, Viktor Mihajlovski wrote: > On 16.02.2018 17:20, Thomas Huth wrote: > [...] >>> diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h >>> index cab8a97..7c3cab8 100644 >>> --- a/hw/s390x/ipl.h >>> +++ b/hw/s390x/ipl.h >>> @@ -60,10 +60,15 @@ typedef struct IplBlockQemuScsi IplBlockQemuScsi; >>> >>> #define QIPL_ADDRESS 0xcc >>> >>> +#define BOOT_MENU_FLAG_CMD_OPTS 0x80 >>> +#define BOOT_MENU_FLAG_ZIPL_OPTS 0x40 >>> + >>> struct QemuIplParameters { >>> - uint8_t reserved1[4]; >>> + uint8_t boot_menu_flags; >>> + uint8_t reserved1; >>> + uint32_t boot_menu_timeout; >>> uint64_t netboot_start_addr; >> The netboot_start_addr field is now never aligned anymore, neither on >> the host side, nor in guest memory. Not a big problem since the struct >> is declared with "QEMU_PACKED", but still ... it's always nicer to try >> to align fields to their natural boundaries. So maybe move >> boot_menu_flags and reserved1 after netboot_start_addr ? >> > Good catch ... we probably should document the alignment needs and state > that the ipl parameters starts on a word boundary (and that the block > may not be larger than 28 bytes) in a comment block. How does this sound? /* word aligned and cannot exceed 28 bytes */ >>> - uint8_t reserved2[16]; >>> + uint8_t reserved2[14]; >>> } QEMU_PACKED; >>> typedef struct QemuIplParameters QemuIplParameters; >> Thomas >> > -- - Collin L Walling