From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Richard Henderson <rth@twiddle.net>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2] cputlb: ensure _cmmu helper functions follow the naming standard
Date: Mon, 21 Oct 2019 09:12:27 -0700 [thread overview]
Message-ID: <0fccf5b5-3fed-cba2-6d06-383252e14652@linaro.org> (raw)
In-Reply-To: <20191021150910.23216-1-alex.bennee@linaro.org>
On 10/21/19 8:09 AM, Alex Bennée wrote:
> We document this in docs/devel/load-stores.rst so lets follow it. The
> 32 bit and 64 bit access functions have historically not included the
> sign so we leave those as is. We also introduce some signed helpers
> which are used for loading immediate values in the translator.
>
> Fixes: 282dffc8
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>
> ---
> v2
> - add signed ldsb and ldsw
> ---
> accel/tcg/cputlb.c | 24 +++++++++++++++++++++---
> include/exec/cpu_ldst_template.h | 4 ++--
> target/cris/translate_v10.inc.c | 3 +--
> tcg/tcg.h | 20 ++++++++++++++------
> 4 files changed, 38 insertions(+), 13 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Queued.
r~
prev parent reply other threads:[~2019-10-21 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 15:09 [PATCH v2] cputlb: ensure _cmmu helper functions follow the naming standard Alex Bennée
2019-10-21 16:12 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fccf5b5-3fed-cba2-6d06-383252e14652@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=edgar.iglesias@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).