From: Gleb Natapov <gleb@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH 1/3] KVM: x86: fix typo in KVM_GET_XCRS
Date: Thu, 21 Nov 2013 15:28:38 +0200 [thread overview]
Message-ID: <0fd53fec92c5b636ef4774fe130f6029fde9fc3c.1385040432.git.gleb@redhat.com> (raw)
In-Reply-To: <cover.1385040432.git.gleb@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Only the first item of the array was ever looked at. No
practical effect, but still worth fixing.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Gleb Natapov <gleb@redhat.com>
---
target-i386/kvm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 749aa09..27071e3 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -1314,8 +1314,8 @@ static int kvm_get_xcrs(X86CPU *cpu)
for (i = 0; i < xcrs.nr_xcrs; i++) {
/* Only support xcr0 now */
- if (xcrs.xcrs[0].xcr == 0) {
- env->xcr0 = xcrs.xcrs[0].value;
+ if (xcrs.xcrs[i].xcr == 0) {
+ env->xcr0 = xcrs.xcrs[i].value;
break;
}
}
--
1.8.4.rc3
next prev parent reply other threads:[~2013-11-21 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 13:28 [Qemu-devel] [PATCH 0/3] [PULL] qemu-kvm.git uq/master queue Gleb Natapov
2013-11-21 13:28 ` Gleb Natapov [this message]
2013-11-21 13:28 ` [Qemu-devel] [PATCH 2/3] pci-assign: Remove dead code for direct I/O region access from userspace Gleb Natapov
2013-11-21 13:28 ` [Qemu-devel] [PATCH 3/3] kvm: Fix uninitialized cpuid_data Gleb Natapov
2013-11-21 17:38 ` [Qemu-devel] [PATCH 0/3] [PULL for 1.7?] qemu-kvm.git uq/master queue Stefan Weil
2013-11-21 18:11 ` Paolo Bonzini
2013-11-21 18:31 ` Gleb Natapov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fd53fec92c5b636ef4774fe130f6029fde9fc3c.1385040432.git.gleb@redhat.com \
--to=gleb@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).