From: "Cédric Le Goater" <clg@kaod.org>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id
Date: Mon, 23 Apr 2018 13:35:56 +0200 [thread overview]
Message-ID: <0fe02e1a-576b-cd6e-a79c-ede821cab983@kaod.org> (raw)
In-Reply-To: <20180423104622.GG2518@work-vm>
>>> I think it's nice to at least do the "bump version" thing, so you
>>> get a (hopefully comprehensible) error rather than just wrong
>>> data if you do try a cross version migration,
>>
>> On that topic, the error message was :
>>
>> Missing section footer for aspeed.timerctrl
>>
>> which is not very comprehensible for a version mismatch issue.
>
> Was that before your patch?
yes.
> The VMSTATE fields in the structure have no metadata stored
> for them to be parsed with; if you send a different number
> of array entries to the number the destination receives you end
> up with a corrupt stream. Section footers are just a canary
> that tells you something went wrong in that devices data.
> It has no more information to give you a more detailed error.
OK. Thanks for the explanation.
C.
prev parent reply other threads:[~2018-04-23 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-23 6:40 [Qemu-devel] [PATCH] timer/aspeed: fix vmstate version id Cédric Le Goater
2018-04-23 9:12 ` Peter Maydell
2018-04-23 9:28 ` Cédric Le Goater
2018-04-23 9:34 ` Peter Maydell
2018-04-23 9:55 ` Cédric Le Goater
2018-04-23 10:00 ` Cédric Le Goater
2018-04-23 10:46 ` Dr. David Alan Gilbert
2018-04-23 11:35 ` Cédric Le Goater [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fe02e1a-576b-cd6e-a79c-ede821cab983@kaod.org \
--to=clg@kaod.org \
--cc=andrew@aj.id.au \
--cc=dgilbert@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).