qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, lvivier@redhat.com, armbru@redhat.com,
	afaerber@suse.de, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fixup! qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts
Date: Wed, 22 Mar 2017 12:39:29 -0500	[thread overview]
Message-ID: <0feec7b2-27f5-76e5-5bf1-f6f020c574df@redhat.com> (raw)
In-Reply-To: <149020412706.102.14127530188115538412@6c512846dbc7>

[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]

On 03/22/2017 12:35 PM, no-reply@patchew.org wrote:
> Hi,
> 
> This series failed build test on s390x host. Please find the details below.
> 
> Type: series
> Subject: [Qemu-devel] [PATCH] fixup! qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts
> Message-id: 20170322173023.22654-1-eblake@redhat.com
> 

> /var/tmp/patchew-tester-tmp-5drz5kus/src/qom/object_interfaces.c: In function ‘user_creatable_add_opts’:
> /var/tmp/patchew-tester-tmp-5drz5kus/src/qom/object_interfaces.c:125:16: error: passing argument 1 of ‘g_free’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
>          g_free(type);
>                 ^~~~

Silly patchew. Maybe we should teach you that any patch with 'fixup!' in
the title is _probably_ not going to compile on its own, because it is a
fixup to be sqaushed to an (as-yet) uncommitted patch.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]

      reply	other threads:[~2017-03-22 17:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 17:30 [Qemu-devel] [PATCH] fixup! qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts Eric Blake
2017-03-22 17:35 ` no-reply
2017-03-22 17:39   ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0feec7b2-27f5-76e5-5bf1-f6f020c574df@redhat.com \
    --to=eblake@redhat.com \
    --cc=afaerber@suse.de \
    --cc=armbru@redhat.com \
    --cc=famz@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).