From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: "Philippe Mathieu-Daudé " <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Igor Skalkin" <Igor.Skalkin@opensynergy.com>,
"Anton Yakovlev" <Anton.Yakovlev@opensynergy.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"ichael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Daniel P. Berrangé " <berrange@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Volker Rü melin" <vr_qemu@t-online.de>, "Kő vá gó ,
Zoltá n" <DirtY.iCE.hu@gmail.com>,
"Alex Benné e" <alex.bennee@linaro.org>
Subject: Re: [PATCH v8 05/12] virtio-sound: handle VIRTIO_SND_R_PCM_INFO request
Date: Mon, 04 Sep 2023 13:24:46 +0300 [thread overview]
Message-ID: <0giah.s27xvtlho1sb@linaro.org> (raw)
In-Reply-To: <30dde76a-099c-1f03-93e3-0c962f15404d@linaro.org>
On Mon, 04 Sep 2023 13:13, Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
>> +
>> + pcm_info = g_new0(virtio_snd_pcm_info, req.count);
>> + for (uint32_t i = req.start_id; i < req.start_id + req.count; i++) {
>
>Starting from req.start_id seems to increase this code complexity.
I see your point, will change it!
Manos
next prev parent reply other threads:[~2023-09-04 10:27 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 19:54 [PATCH v8 00/12] Add VIRTIO sound card Emmanouil Pitsidianakis
2023-08-28 19:54 ` [PATCH v8 01/12] Add virtio-sound device stub Emmanouil Pitsidianakis
2023-08-28 19:54 ` [PATCH v8 02/12] Add virtio-sound-pci device Emmanouil Pitsidianakis
2023-09-04 6:32 ` Volker Rümelin
2023-09-04 10:26 ` Manos Pitsidianakis
2023-09-04 21:08 ` Volker Rümelin
2023-09-06 9:05 ` Mark Cave-Ayland
2023-08-28 19:55 ` [PATCH v8 03/12] virtio-sound: handle control messages and streams Emmanouil Pitsidianakis
2023-09-04 10:08 ` Philippe Mathieu-Daudé
2023-09-04 10:18 ` Manos Pitsidianakis
2023-09-04 10:42 ` Philippe Mathieu-Daudé
2023-09-04 10:46 ` Philippe Mathieu-Daudé
2023-09-04 11:00 ` Manos Pitsidianakis
2023-09-04 11:30 ` Philippe Mathieu-Daudé
2023-09-04 11:46 ` Manos Pitsidianakis
2023-09-04 12:17 ` Philippe Mathieu-Daudé
2023-09-06 9:29 ` Mark Cave-Ayland
2023-08-28 19:55 ` [PATCH v8 04/12] virtio-sound: set PCM stream parameters Emmanouil Pitsidianakis
2023-08-29 19:27 ` Alex Bennée
2023-08-28 19:55 ` [PATCH v8 05/12] virtio-sound: handle VIRTIO_SND_R_PCM_INFO request Emmanouil Pitsidianakis
2023-08-29 19:31 ` Alex Bennée
2023-09-04 10:13 ` Philippe Mathieu-Daudé
2023-09-04 10:24 ` Manos Pitsidianakis [this message]
2023-08-28 19:55 ` [PATCH v8 06/12] virtio-sound: handle VIRTIO_SND_R_PCM_{START,STOP} Emmanouil Pitsidianakis
2023-08-29 19:32 ` Alex Bennée
2023-08-28 19:55 ` [PATCH v8 07/12] virtio-sound: handle VIRTIO_SND_R_PCM_SET_PARAMS Emmanouil Pitsidianakis
2023-08-29 19:33 ` Alex Bennée
2023-08-28 19:55 ` [PATCH v8 08/12] virtio-sound: handle VIRTIO_SND_R_PCM_PREPARE Emmanouil Pitsidianakis
2023-08-29 19:33 ` Alex Bennée
2023-08-28 19:55 ` [PATCH v8 09/12] virtio-sound: handle VIRTIO_SND_R_PCM_RELEASE Emmanouil Pitsidianakis
2023-08-29 19:34 ` Alex Bennée
2023-08-28 19:55 ` [PATCH v8 10/12] virtio-sound: implement audio output (TX) Emmanouil Pitsidianakis
2023-08-30 13:39 ` Alex Bennée
2023-09-04 10:26 ` Philippe Mathieu-Daudé
2023-09-04 10:34 ` Manos Pitsidianakis
2023-09-04 11:39 ` Philippe Mathieu-Daudé
2023-09-04 21:34 ` Volker Rümelin
2023-09-05 7:10 ` Volker Rümelin
2023-08-28 19:55 ` [PATCH v8 11/12] virtio-sound: implement audio capture (RX) Emmanouil Pitsidianakis
2023-08-30 13:40 ` Alex Bennée
2023-09-08 6:49 ` Volker Rümelin
2023-09-09 8:56 ` Volker Rümelin
2023-08-28 19:55 ` [PATCH v8 12/12] docs/system: add basic virtio-snd documentation Emmanouil Pitsidianakis
2023-08-30 17:49 ` Alex Bennée
2023-08-30 13:40 ` [PATCH v8 00/12] Add VIRTIO sound card Alex Bennée
2023-09-04 7:20 ` Volker Rümelin
2023-09-04 10:01 ` Manos Pitsidianakis
2023-09-04 12:11 ` Alex Bennée
2023-09-05 6:03 ` Volker Rümelin
2023-09-05 6:56 ` Volker Rümelin
2023-09-06 8:39 ` Matias Ezequiel Vara Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0giah.s27xvtlho1sb@linaro.org \
--to=manos.pitsidianakis@linaro.org \
--cc=Anton.Yakovlev@opensynergy.com \
--cc=DirtY.iCE.hu@gmail.com \
--cc=Igor.Skalkin@opensynergy.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).