From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD933C10DCE for ; Fri, 13 Mar 2020 14:26:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B284E20746 for ; Fri, 13 Mar 2020 14:26:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B284E20746 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jClH5-0007zU-U8 for qemu-devel@archiver.kernel.org; Fri, 13 Mar 2020 10:26:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48586) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jClG7-0006h0-RY for qemu-devel@nongnu.org; Fri, 13 Mar 2020 10:25:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jClG6-0006nm-JU for qemu-devel@nongnu.org; Fri, 13 Mar 2020 10:25:55 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:6006) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jClG6-0006kf-BB for qemu-devel@nongnu.org; Fri, 13 Mar 2020 10:25:54 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02DEPa1a098561 for ; Fri, 13 Mar 2020 10:25:53 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2yqxhshmsg-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 13 Mar 2020 10:25:50 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Mar 2020 14:21:13 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 13 Mar 2020 14:21:10 -0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02DEL8t562128370 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Mar 2020 14:21:08 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CEC7742045; Fri, 13 Mar 2020 14:21:08 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7AB7842041; Fri, 13 Mar 2020 14:21:08 +0000 (GMT) Received: from localhost.localdomain (unknown [9.145.48.117]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Fri, 13 Mar 2020 14:21:08 +0000 (GMT) Subject: Re: [PATCH v9 09/15] s390x: protvirt: Set guest IPL PSW To: Claudio Imbrenda References: <20200311132151.172389-1-frankja@linux.ibm.com> <20200311132151.172389-10-frankja@linux.ibm.com> <20200313135733.634c0008@p-imbrenda> From: Janosch Frank Autocrypt: addr=frankja@linux.ibm.com; prefer-encrypt=mutual; keydata= mQINBFubpD4BEADX0uhkRhkj2AVn7kI4IuPY3A8xKat0ihuPDXbynUC77mNox7yvK3X5QBO6 qLqYr+qrG3buymJJRD9xkp4mqgasHdB5WR9MhXWKH08EvtvAMkEJLnqxgbqf8td3pCQ2cEpv 15mH49iKSmlTcJ+PvJpGZcq/jE42u9/0YFHhozm8GfQdb9SOI/wBSsOqcXcLTUeAvbdqSBZe zuMRBivJQQI1esD9HuADmxdE7c4AeMlap9MvxvUtWk4ZJ/1Z3swMVCGzZb2Xg/9jZpLsyQzb lDbbTlEeyBACeED7DYLZI3d0SFKeJZ1SUyMmSOcr9zeSh4S4h4w8xgDDGmeDVygBQZa1HaoL Esb8Y4avOYIgYDhgkCh0nol7XQ5i/yKLtnNThubAcxNyryw1xSstnKlxPRoxtqTsxMAiSekk 0m3WJwvwd1s878HrQNK0orWd8BzzlSswzjNfQYLF466JOjHPWFOok9pzRs+ucrs6MUwDJj0S cITWU9Rxb04XyigY4XmZ8dywaxwi2ZVTEg+MD+sPmRrTw+5F+sU83cUstuymF3w1GmyofgsU Z+/ldjToHnq21MNa1wx0lCEipCCyE/8K9B9bg9pUwy5lfx7yORP3JuAUfCYb8DVSHWBPHKNj HTOLb2g2UT65AjZEQE95U2AY9iYm5usMqaWD39pAHfhC09/7NQARAQABtCVKYW5vc2NoIEZy YW5rIDxmcmFua2phQGxpbnV4LmlibS5jb20+iQI3BBMBCAAhBQJbm6Q+AhsjBQsJCAcCBhUI CQoLAgQWAgMBAh4BAheAAAoJEONU5rjiOLn4p9gQALjkdj5euJVI2nNT3/IAxAhQSmRhPEt0 AmnCYnuTcHRWPujNr5kqgtyER9+EMQ0ZkX44JU2q7OWxTdSNSAN/5Z7qmOR9JySvDOf4d3mS bMB5zxL9d8SbnSs1uW96H9ZBTlTQnmLfsiM9TetAjSrR8nUmjGhe2YUhJLR1v1LguME+YseT eXnLzIzqqpu311/eYiiIGcmaOjPCE+vFjcXL5oLnGUE73qSYiujwhfPCCUK0850o1fUAYq5p CNBCoKT4OddZR+0itKc/cT6NwEDwdokeg0+rAhxb4Rv5oFO70lziBplEjOxu3dqgIKbHbjza EXTb+mr7VI9O4tTdqrwJo2q9zLqqOfDBi7NDvZFLzaCewhbdEpDYVu6/WxprAY94hY3F4trT rQMHJKQENtF6ZTQc9fcT5I3gAmP+OEvDE5hcTALpWm6Z6SzxO7gEYCnF+qGXqp8sJVrweMub UscyLqHoqdZC2UG4LQ1OJ97nzDpIRe0g6oJ9ZIYHKmfw5jjwH6rASTld5MFWajWdNsqK15k/ RZnHAGICKVIBOBsq26m4EsBlfCdt3b/6emuBjUXR1pyjHMz2awWzCq6/6OWs5eANZ0sdosNq dq2v0ULYTazJz2rlCXV89qRa7ukkNwdBSZNEwsD4eEMicj1LSrqWDZMAALw50L4jxaMD7lPL jJbauQINBFubpD4BEADAcUTRqXF/aY53OSH7IwIK9lFKxIm0IoFkOEh7LMfp7FGzaP7ANrZd cIzhZi38xyOkcaFY+npGEWvko7rlIAn0JpBO4x3hfhmhBD/WSY8LQIFQNNjEm3vzrMo7b9Jb JAqQxfbURY3Dql3GUzeWTG9uaJ00u+EEPlY8zcVShDltIl5PLih20e8xgTnNzx5c110lQSu0 iZv2lAE6DM+2bJQTsMSYiwKlwTuv9LI9Chnoo6+tsN55NqyMxYqJgElk3VzlTXSr3+rtSCwf tq2cinETbzxc1XuhIX6pu/aCGnNfuEkM34b7G1D6CPzDMqokNFbyoO6DQ1+fW6c5gctXg/lZ 602iEl4C4rgcr3+EpfoPUWzKeM8JXv5Kpq4YDxhvbitr8Dm8gr38+UKFZKlWLlwhQ56r/zAU v6LIsm11GmFs2/cmgD1bqBTNHHcTWwWtRTLgmnqJbVisMJuYJt4KNPqphTWsPY8SEtbufIlY HXOJ2lqUzOReTrie2u0qcSvGAbSfec9apTFl2Xko/ddqPcZMpKhBiXmY8tJzSPk3+G4tqur4 6TYAm5ouitJsgAR61Cu7s+PNuq/pTLDhK+6/Njmc94NGBcRA4qTuysEGE79vYWP2oIAU4Fv6 gqaWHZ4MEI2XTqH8wiwzPdCQPYsSE0fXWiYu7ObeErT6iLSTZGx4rQARAQABiQIfBBgBCAAJ BQJbm6Q+AhsMAAoJEONU5rjiOLn4DDEP/RuyckW65SZcPG4cMfNgWxZF8rVjeVl/9PBfy01K 8R0hajU40bWtXSMiby7j0/dMjz99jN6L+AJHJvrLz4qYRzn2Ys843W+RfXj62Zde4YNBE5SL jJweRCbMWKaJLj6499fctxTyeb9+AMLQS4yRSwHuAZLmAb5AyCW1gBcTWZb8ON5BmWnRqeGm IgC1EvCnHy++aBnHTn0m+zV89BhTLTUal35tcjUFwluBY39R2ux/HNlBO1GY3Z+WYXhBvq7q katThLjaQSmnOrMhzqYmdShP1leFTVbzXUUIYv/GbynO/YrL2gaQpaP1bEUEi8lUAfXJbEWG dnHFkciryi092E8/9j89DJg4mmZqOau7TtUxjRMlBcIliXkzSLUk+QvD4LK1kWievJse4mte FBdkWHfP4BH/+8DxapRcG1UAheSnSRQ5LiO50annOB7oXF+vgKIaie2TBfZxQNGAs3RQ+bga DchCqFm5adiSP5+OT4NjkKUeGpBe/aRyQSle/RropTgCi85pje/juYEn2P9UAgkfBJrOHvQ9 Z+2Sva8FRd61NJLkCJ4LFumRn9wQlX2icFbi8UDV3do0hXJRRYTWCxrHscMhkrFWLhYiPF4i phX7UNdOWBQ90qpHyAxHmDazdo27gEjfvsgYMdveKknEOTEb5phwxWgg7BcIDoJf9UMC Date: Fri, 13 Mar 2020 15:21:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200313135733.634c0008@p-imbrenda> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vWbVixXpOsa1rC9eeWasO8SSAxkvHwjyj" X-TM-AS-GCONF: 00 x-cbid: 20031314-0008-0000-0000-0000035CAA66 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20031314-0009-0000-0000-00004A7DF7B5 Message-Id: <10063e5d-7c4f-da0b-fe20-c8d94c958111@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-03-13_05:2020-03-12, 2020-03-13 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 adultscore=0 impostorscore=0 priorityscore=1501 phishscore=0 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 suspectscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003130074 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 148.163.156.1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: borntraeger@de.ibm.com, qemu-s390x@nongnu.org, cohuck@redhat.com, qemu-devel@nongnu.org, david@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vWbVixXpOsa1rC9eeWasO8SSAxkvHwjyj Content-Type: multipart/mixed; boundary="VQgWkPmSiIpVuU9YgkKqabaD4GSwdmMC0" --VQgWkPmSiIpVuU9YgkKqabaD4GSwdmMC0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 3/13/20 1:57 PM, Claudio Imbrenda wrote: > On Wed, 11 Mar 2020 09:21:45 -0400 > Janosch Frank wrote: >=20 >> Handling of CPU reset and setting of the IPL psw from guest storage at= >> offset 0 is done by a Ultravisor call. Let's only fetch it if >> necessary. >> >> Signed-off-by: Janosch Frank >> Reviewed-by: Thomas Huth >> Reviewed-by: David Hildenbrand >> --- >> target/s390x/cpu.c | 22 +++++++++++++--------- >> 1 file changed, 13 insertions(+), 9 deletions(-) >> >> diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c >> index 84029f14814b4980..a48d39f139cdc1c4 100644 >> --- a/target/s390x/cpu.c >> +++ b/target/s390x/cpu.c >> @@ -78,16 +78,20 @@ static bool s390_cpu_has_work(CPUState *cs) >> static void s390_cpu_load_normal(CPUState *s) >> { >> S390CPU *cpu =3D S390_CPU(s); >> - uint64_t spsw =3D ldq_phys(s->as, 0); >> - >> - cpu->env.psw.mask =3D spsw & PSW_MASK_SHORT_CTRL; >> - /* >> - * Invert short psw indication, so SIE will report a >> specification >> - * exception if it was not set. >> - */ >> - cpu->env.psw.mask ^=3D PSW_MASK_SHORTPSW; >> - cpu->env.psw.addr =3D spsw & PSW_MASK_SHORT_ADDR; >> + uint64_t spsw; >> =20 >> + if (!s390_is_pv()) { >> + spsw =3D ldq_phys(s->as, 0); >> + cpu->env.psw.mask =3D spsw & PSW_MASK_SHORT_CTRL; >> + /* >> + * Invert short psw indication, so SIE will report a >> specification >> + * exception if it was not set. >> + */ >> + cpu->env.psw.mask ^=3D PSW_MASK_SHORTPSW; >> + cpu->env.psw.addr =3D spsw & PSW_MASK_SHORT_ADDR; >> + } else { >> + s390_cpu_set_state(S390_CPU_STATE_LOAD, cpu); >> + } >> s390_cpu_set_state(S390_CPU_STATE_OPERATING, cpu); >> } >> #endif >=20 > I don't understand why you set the state to S390_CPU_STATE_LOAD and > then immediately afterwards to S390_CPU_STATE_OPERATING, especially > considering that both do the same >=20 Have a look at the specs, wee need to set the load state before setting the cpu to operating. I can add a comment to make it clearer if you want. --VQgWkPmSiIpVuU9YgkKqabaD4GSwdmMC0-- --vWbVixXpOsa1rC9eeWasO8SSAxkvHwjyj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEwGNS88vfc9+v45Yq41TmuOI4ufgFAl5rltMACgkQ41TmuOI4 ufga2g//ffq9Uoh126oen4/7nRlmopdZ5lF5UFm7BjQwBcioo4PIu2F+dzMbLJ9x X0PFH5MMQpvFjSxyiC8bZW3Isaf+nF5whxXaNF+SKuQb7V1/6H5SwS/oZEsZ8XZe wEsiK2lDXgjkIhGnMsWsVPuiu8gLx2LHQnoLwiPtMr8RxkDSkX++BUgUL0W93bMu zj1u+m9EQlccYTajg2pJiblFrFC21Q9U1vGuzg4Q8pC60rBkRUhywvX8izmjwanB LCnB3TgDGCE7CVy2UxOAHsOa5kj3RDFiEbM5nenQoIi7LU8y1ARhhdZnVjm2EiVX ztUbskYlEn2b2CLTbGARyeRv9EknaRpWOMt1tjLFBGKVg4DWUf4GxGfrqtHlg7QK 1IEcU40+GEWyqzp2yJZ3807gNroiKFo1b0x7XqP6+qweM6aYL2P4voFYUscShfbK CDX7BX7QQq3lfhhKALHHrnBD2ZBBfBJgOv7M26+HyQNa/V64BGJZyS6Lwhyv8uWX S6Frv1SWhL8hxcvwf72N1ydY1A+9mGFUihkUGTHq83lGDme2DkT1RRC9F+EtlGOx aLfuflseAXKrCoIN2G+eihfXbV2X5zIgr4npMsZE2i6puhiReH4YiTL/ea01wNPu 3EZf/U1FrZ4VAiMjefXx2/WrItWTGK3NDKvKBFWJXlcWdNRS00U= =llDD -----END PGP SIGNATURE----- --vWbVixXpOsa1rC9eeWasO8SSAxkvHwjyj--