Re: [PATCH 1/1] dirty-bitmaps: remove deprecated autoload parameter

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1273 bytes --]

On 9/24/19 6:01 PM, John Snow wrote:
> This parameter has been deprecated since 2.12.0 and is eligible for
> removal. Remove this parameter as it is actually completely ignored;
> let's not give false hope.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  qemu-deprecated.texi | 20 +++++++++++++++-----
>  qapi/block-core.json |  6 +-----
>  blockdev.c           |  6 ------
>  3 files changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> index 01245e0b1c..d60246d5d6 100644
> --- a/qemu-deprecated.texi
> +++ b/qemu-deprecated.texi

> +@node Recently removed features
> +@appendix Recently removed features
> +
> +What follows is a record of recently removed, formerly deprecated
> +features that serves as a record for users who have encountered
> +trouble after a recent upgrade.
> +
> +@section QEMU Machine Protocol (QMP) commands
> +
> +@subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0)

Do we want to state 'since 4.2' here, as the point where it was removed?

Otherwise,

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]