[PATCH v2 0/1] meson: Remove libibumad dependence

[PATCH v2 0/1] meson: Remove libibumad dependence

[zhenwei pi]

v1 -> v2: remove libibumad from tests/lcitool/projects/qemu.yml

v1: remove libibumad dependence

Zhenwei Pi (1):
  meson: Remove libibumad dependence

 meson.build                     | 4 +---
 tests/lcitool/projects/qemu.yml | 1 -
 2 files changed, 1 insertion(+), 4 deletions(-)

-- 
2.34.1

[PATCH v2 1/1] meson: Remove libibumad dependence

[zhenwei pi]

RDMA based migration has no dependence on libumad. libibverbs and
librdmacm are enough.
libumad was used by rdmacm-mux which has been already removed. It's
remained mistakenly.

Fixes: 1dfd42c4264b ("hw/rdma: Remove deprecated pvrdma device and rdmacm-mux helper")
Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
---
 meson.build                     | 4 +---
 tests/lcitool/projects/qemu.yml | 1 -
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/meson.build b/meson.build
index ec59effca2..226b97ea26 100644
--- a/meson.build
+++ b/meson.build
@@ -1885,11 +1885,9 @@ endif
 
 rdma = not_found
 if not get_option('rdma').auto() or have_system
-  libumad = cc.find_library('ibumad', required: get_option('rdma'))
   rdma_libs = [cc.find_library('rdmacm', has_headers: ['rdma/rdma_cma.h'],
                                required: get_option('rdma')),
-               cc.find_library('ibverbs', required: get_option('rdma')),
-               libumad]
+               cc.find_library('ibverbs', required: get_option('rdma'))]
   rdma = declare_dependency(dependencies: rdma_libs)
   foreach lib: rdma_libs
     if not lib.found()
diff --git a/tests/lcitool/projects/qemu.yml b/tests/lcitool/projects/qemu.yml
index 070d7f4706..0c85784259 100644
--- a/tests/lcitool/projects/qemu.yml
+++ b/tests/lcitool/projects/qemu.yml
@@ -47,7 +47,6 @@ packages:
  - libfdt
  - libffi
  - libgcrypt
- - libibumad
  - libibverbs
  - libiscsi
  - libjemalloc
-- 
2.34.1

Re: [PATCH v2 1/1] meson: Remove libibumad dependence

[Philippe Mathieu-Daudé]

On 11/6/24 11:27, zhenwei pi wrote:
> RDMA based migration has no dependence on libumad. libibverbs and
> librdmacm are enough.
> libumad was used by rdmacm-mux which has been already removed. It's
> remained mistakenly.
> 
> Fixes: 1dfd42c4264b ("hw/rdma: Remove deprecated pvrdma device and rdmacm-mux helper")
> Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
>   meson.build                     | 4 +---
>   tests/lcitool/projects/qemu.yml | 1 -
>   2 files changed, 1 insertion(+), 4 deletions(-)


> diff --git a/tests/lcitool/projects/qemu.yml b/tests/lcitool/projects/qemu.yml
> index 070d7f4706..0c85784259 100644
> --- a/tests/lcitool/projects/qemu.yml
> +++ b/tests/lcitool/projects/qemu.yml
> @@ -47,7 +47,6 @@ packages:
>    - libfdt
>    - libffi
>    - libgcrypt
> - - libibumad
>    - libibverbs
>    - libiscsi
>    - libjemalloc

You didn't run "make lcitool-refresh", see:
https://www.qemu.org/docs/master/devel/testing#adding-new-build-pre-requisites