From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55659)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1Ux0rv-0001xE-NV
	for qemu-devel@nongnu.org; Wed, 10 Jul 2013 16:20:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pmoore@redhat.com>) id 1Ux0ru-0006sG-IZ
	for qemu-devel@nongnu.org; Wed, 10 Jul 2013 16:20:07 -0400
From: Paul Moore <pmoore@redhat.com>
Date: Wed, 10 Jul 2013 16:19:58 -0400
Message-ID: <10103036.K9bhvYI3HI@sifl>
In-Reply-To: <51DDBDEF.7060209@suse.de>
References: <20130529203001.20939.83322.stgit@localhost>
	<1536749.nyBeeYseQi@sifl> <51DDBDEF.7060209@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"
Subject: Re: [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls
	to the whitelist
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?ISO-8859-1?Q?F=E4rber?= <afaerber@suse.de>
Cc: qemu-stable <qemu-stable@nongnu.org>, coreyb@linux.vnet.ibm.com, qemu-devel@nongnu.org, otubo@linux.vnet.ibm.com

On Wednesday, July 10, 2013 10:02:55 PM Andreas F=E4rber wrote:
> Am 10.07.2013 16:31, schrieb Paul Moore:
> > On Wednesday, May 29, 2013 04:30:01 PM Paul Moore wrote:
> >> In order to enable the asynchronous I/O functionality when using t=
he
> >> seccomp sandbox we need to add the associated syscalls to the
> >> whitelist.
> >>=20
> >> Signed-off-by: Paul Moore <pmoore@redhat.com>
> >> ---
> >>=20
> >>  qemu-seccomp.c |    5 ++++-
> >>  1 file changed, 4 insertions(+), 1 deletion(-)
> >>=20
> >> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> >> index 031da1d..ca123bf 100644
> >> --- a/qemu-seccomp.c
> >> +++ b/qemu-seccomp.c
> >> @@ -87,6 +87,7 @@ static const struct QemuSeccompSyscall
> >> seccomp_whitelist[] =3D { { SCMP_SYS(stat), 245 },
> >>=20
> >>      { SCMP_SYS(uname), 245 },
> >>      { SCMP_SYS(eventfd2), 245 },
> >>=20
> >> +    { SCMP_SYS(io_getevents), 245 },
> >>=20
> >>      { SCMP_SYS(dup), 245 },
> >>      { SCMP_SYS(dup2), 245 },
> >>      { SCMP_SYS(dup3), 245 },
> >>=20
> >> @@ -229,7 +230,9 @@ static const struct QemuSeccompSyscall
> >> seccomp_whitelist[] =3D { { SCMP_SYS(sendmmsg), 241 },
> >>=20
> >>      { SCMP_SYS(recvmmsg), 241 },
> >>      { SCMP_SYS(prlimit64), 241 },
> >>=20
> >> -    { SCMP_SYS(waitid), 241 }
> >> +    { SCMP_SYS(waitid), 241 },
> >> +    { SCMP_SYS(io_setup), 241 },
> >> +    { SCMP_SYS(io_destroy), 241 }
> >>=20
> >>  };
> >> =20
> >>  int seccomp_start(void)
> >=20
> > Any reason this patch wasn't pulled in for 1.5.1?
>=20
> Yes: You forget to put a line Cc: qemu-stable@nongnu.org into the com=
mit
> message nor was it ever CC'ed while on the list. ;)

You learn something new everyday, thanks.

Can I assume this will make it into 1.5.2 now?

--=20
paul moore
security and virtualization @ redhat