From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C32ECC433DF for ; Mon, 25 May 2020 12:28:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DDB820812 for ; Mon, 25 May 2020 12:28:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y2yDpvpt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DDB820812 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jdCDx-00054s-Pd for qemu-devel@archiver.kernel.org; Mon, 25 May 2020 08:28:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36758) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdCCP-0003xA-2e for qemu-devel@nongnu.org; Mon, 25 May 2020 08:27:21 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:42873 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jdCCO-0003oM-9C for qemu-devel@nongnu.org; Mon, 25 May 2020 08:27:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590409639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ET1vOPjbo0umRF7Qk+Zm/dRolTdxt0oIXTEqOMzcCbg=; b=Y2yDpvptEMupddffatmQZ0IZ868a9AFzwbGGUQPIdl9381wSDJhWk0VgEYBNVslJzISIcK GUkWy/r/F81Izaq4Qepykw7tKUJEQ8akWaGbD1kLo8IZbvW7+GPba6OrCvbYpxoMwDkXhV bCZynO14zPr111YjYkzSyrCsCFs/NPg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-67-MBUZK4oTPl6Vg3lgY4pEKg-1; Mon, 25 May 2020 08:27:17 -0400 X-MC-Unique: MBUZK4oTPl6Vg3lgY4pEKg-1 Received: by mail-wr1-f72.google.com with SMTP id l18so3053768wrm.0 for ; Mon, 25 May 2020 05:27:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ET1vOPjbo0umRF7Qk+Zm/dRolTdxt0oIXTEqOMzcCbg=; b=T4HwquDbiamSHq1Xqvs+Y2lZE7BBIwb05dhWES7JpSumGlXee6SBC3fFAtfiEI0hy2 XXiHeTymxQageJvR9xfa6MUNRzBTA6kSlU+i9E87oN8sc+Vi3oCnwkILwy/qEYdLBARi XHr0rPY3mbnJb0EF7svTtjNeXz1DSpLNVwJUJK6oDlqyZc3Y6zyuJVJVBQmJQ1Gpi91O jNKWMauv+DI0sLKuyB2P8wH8aqfk2xiBCSExneW4sLzDyd4AJxxfKn52wWl2Cu9P63SB Q6c018uw5st68guyx0CfbQrIwkAoqQniS5FEy7Po2EwkW/C/7hKwE5FMHziw7oqN8eni mXtQ== X-Gm-Message-State: AOAM533YCgb2KkHaL7YmZvLKyva5frT8fE+hvaYVQ2ZjkrxZRs80MwgD 3wzVoQxrMzOZs/neTcLYts0rP50ZPGCha+Zei2F/DJPp/KyB0IGg2eDb9o0Yc0jjYl1jv79pjxV HTyBjnwRdEc4QKFc= X-Received: by 2002:a05:6000:1009:: with SMTP id a9mr16260202wrx.403.1590409635687; Mon, 25 May 2020 05:27:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWBquywfGi65ZmRKEStBzCR8EshGuQl9iIvJM3LVJgF6WSlB/7WnBbL2wcXQdDlfflB0Vf0w== X-Received: by 2002:a05:6000:1009:: with SMTP id a9mr16260175wrx.403.1590409635402; Mon, 25 May 2020 05:27:15 -0700 (PDT) Received: from [192.168.1.36] (71.red-88-21-204.staticip.rima-tde.net. [88.21.204.71]) by smtp.gmail.com with ESMTPSA id l5sm10104037wml.27.2020.05.25.05.27.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2020 05:27:14 -0700 (PDT) Subject: Re: [PATCH v3 15/22] microvm: make virtio irq base runtime configurable To: Gerd Hoffmann References: <20200520132003.9492-1-kraxel@redhat.com> <20200520132003.9492-16-kraxel@redhat.com> <3e0451d7-5692-10b3-ac01-90128765643e@redhat.com> <20200525114928.lxfqu2uo5xfhtywx@sirius.home.kraxel.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: <101618ac-a1ed-6f5c-df4e-5238ce9e31f2@redhat.com> Date: Mon, 25 May 2020 14:27:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200525114928.lxfqu2uo5xfhtywx@sirius.home.kraxel.org> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=207.211.31.81; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/25 06:55:03 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , Sergio Lopez , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Shannon Zhao , qemu-arm@nongnu.org, Igor Mammedov , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/25/20 1:49 PM, Gerd Hoffmann wrote: > Hi, > >>> -#define VIRTIO_IRQ_BASE 5 > >>> + mms->virtio_irq_base = 8; >> >> Hmm you made it runtime configurable indeed, but you also changed it from 5 >> to 8. Worth a different patch, or at least mentioning in commit description. > > Oops, that wasn't intentional. I'll change it back to 5. OK. Using 5: Reviewed-by: Philippe Mathieu-Daudé