From: Paolo Bonzini <pbonzini@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qmp: handle stop/cont in INMIGRATE state
Date: Fri, 19 Oct 2012 05:27:29 -0400 (EDT) [thread overview]
Message-ID: <1020421226.13368559.1350638849130.JavaMail.root@redhat.com> (raw)
In-Reply-To: <20121018134256.5f6d745d@doriath.home>
> What happens is that a stop command while in INMIGRATE state will just
> be ignored. Actually, any stops while in a state that pauses vCPUs
> are ignored.
>
> Also, I don't understand what you meant by "racy", care to elaborate?
Case 1: Case 2:
user runs qemu -incoming -S user runs qemu -incoming -S
source connects cont command received
cont command received source connects
In case 1, the VM is resumed at the end of migration, in case 2 it
is not and an error is reported on QMP. After this patch, it is always
resumed.
Case 1: Case 2:
user runs qemu -incoming user runs qemu -incoming
source connects stop command received
stop command received source connects
In case 1, the VM runs for a blink of an eye and then stops. In case
2 it just starts, with no error reported.
> > In addition, there's nothing that really prevents the user from
> > typing the block device's passwords before incoming migration is
> > done, so we may as well allow that.
>
> Have you tried it? We seem to support that already.
With HMP yes, with QMP no. You just get "An incoming migration is
expected before this command can be executed" and no clue that disks
are encrypted.
Paolo
next prev parent reply other threads:[~2012-10-19 9:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 9:14 [Qemu-devel] [PATCH] qmp: handle stop/cont in INMIGRATE state Paolo Bonzini
2012-10-18 16:42 ` Luiz Capitulino
2012-10-19 9:27 ` Paolo Bonzini [this message]
2012-10-19 13:23 ` Luiz Capitulino
2012-10-19 13:50 ` Paolo Bonzini
2012-10-19 14:02 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1020421226.13368559.1350638849130.JavaMail.root@redhat.com \
--to=pbonzini@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).