From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhi2m-0004W3-Qj for qemu-devel@nongnu.org; Wed, 07 Sep 2016 14:57:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhi2i-0005mr-KZ for qemu-devel@nongnu.org; Wed, 07 Sep 2016 14:57:55 -0400 Received: from mx6-phx2.redhat.com ([209.132.183.39]:55636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhi2i-0005mn-CU for qemu-devel@nongnu.org; Wed, 07 Sep 2016 14:57:52 -0400 Date: Wed, 7 Sep 2016 14:57:50 -0400 (EDT) From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Message-ID: <1024015617.622273.1473274670146.JavaMail.zimbra@redhat.com> In-Reply-To: <644501471.140688.1473176014062.JavaMail.zimbra@redhat.com> References: <20160906122639.11163-1-marcandre.lureau@redhat.com> <644501471.140688.1473176014062.JavaMail.zimbra@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 00/26] Leak patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , QEMU Developers Hi ----- Original Message ----- > Hi >=20 > ----- Original Message ----- > > On 6 September 2016 at 13:26, Marc-Andr=C3=A9 Lureau > > wrote: > > > The following changes since commit > > > 1fd66154fdf8305e6668a96046a22b863b4d7320: > > > > > > Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20160905= ' > > > into > > > staging (2016-09-06 11:43:18 +0100) > > > > > > are available in the git repository at: > > > > > > git@github.com:elmarco/qemu.git tags/leak-pull-request > > > > > > for you to fetch changes up to 58d104a7f2698ffff3ee5976f96ebcff111be6= 3b: > > > > > > tests: fix postcopy-test leaks (2016-09-06 16:20:27 +0400) > > > > > > ---------------------------------------------------------------- > >=20 > > I'm afraid this doesn't build with our minimum glib version: > >=20 > > /Users/pm215/src/qemu-for-merges/tests/libqtest.c:771:42: error: expect= ed > > ')' > > (GTestFixtureFunc) fn, (GTestFixtureFunc) > > data_free_func); > > ^ > > /Users/pm215/src/qemu-for-merges/tests/libqtest.c:770:22: note: to > > match this '(' > > g_test_add_vtable(path, 0, data, NULL, > > ^ > > 1 error generated. > >=20 > > The GTestFixtureFunc typedef was only introduced in glib 2.28, and our > > minimum is 2.22. >=20 > Argh,.. >=20 > >=20 > > Also, g_test_add_vtable() in glib 2.22 has this prototype: > >=20 > > void g_test_add_vtable (const char *testpath, > > gsize data_size, > > gconstpointer test_data, > > void (*data_setup) > > (void), > > void (*data_test) > > (void), > > void (*data_teardown) > > (void)); > >=20 > > but GTestFixtureFunc is typedefed in newer glib as > > void (*GTestFixtureFunc) (gpointer fixture, gconstpointer user_data); > >=20 > > so it looks like this function has changed signature somewhere > > between glib versions, which makes me a bit nervous about using it. >=20 > Perhaps we should get back to the simpler version, only using > g_test_add_data_func_full() with 2.34: > https://patchwork.kernel.org/patch/9251373/ >=20 > I can update the patch that way with a comment about expected leaks < 2.3= 4. >=20 Eric, since you suggested some compat code for older versions, would you be= fine with the above plan? I can send a new patch for review.