qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>,
	Richard Henderson <richard.henderson@linaro.org>,
	"Daniel P . Berrange" <berrange@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/2] meson: Explicit TCG backend used
Date: Fri, 22 Jan 2021 10:41:07 +0100	[thread overview]
Message-ID: <1029e65b-38b8-9e89-1f21-b075e29ffe76@redhat.com> (raw)
In-Reply-To: <20210122092205.1855659-2-philmd@redhat.com>

On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   meson.build | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 8535a83fb70..0a645e54662 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2419,8 +2419,12 @@
>   endif
>   summary_info += {'TCG support':       config_all.has_key('CONFIG_TCG')}
>   if config_all.has_key('CONFIG_TCG')
> +  if config_host.has_key('CONFIG_TCG_INTERPRETER')
> +    summary_info += {'TCG backend':   'TCG interpreter (experimental)'}

maybe say "experimental and slow" in the parentheses?

> +  else
> +    summary_info += {'TCG backend':   'native (@0@)'.format(cpu)}
> +  endif
>     summary_info += {'TCG debug enabled': config_host.has_key('CONFIG_DEBUG_TCG')}
> -  summary_info += {'TCG interpreter':   config_host.has_key('CONFIG_TCG_INTERPRETER')}
>   endif
>   summary_info += {'target list':       ' '.join(target_dirs)}
>   if have_system
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>



  reply	other threads:[~2021-01-22  9:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22  9:22 [PATCH 0/2] meson: Try to clarify TCG / TCI options for new users Philippe Mathieu-Daudé
2021-01-22  9:22 ` [PATCH 1/2] meson: Explicit TCG backend used Philippe Mathieu-Daudé
2021-01-22  9:41   ` Thomas Huth [this message]
2021-01-22  9:22 ` [PATCH 2/2] meson: Warn when TCI is selected but TCG backend is available Philippe Mathieu-Daudé
2021-01-22  9:43   ` Thomas Huth
2021-01-22  9:46     ` Philippe Mathieu-Daudé
2021-01-22  9:47       ` Thomas Huth
2021-01-22  9:56         ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1029e65b-38b8-9e89-1f21-b075e29ffe76@redhat.com \
    --to=thuth@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).