qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Yonggang Luo" <luoyonggang@gmail.com>,
	"Jintao Yin" <nicememory@gmail.com>,
	qemu-trivial@nongnu.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Bin Meng" <bin.meng@windriver.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] cirrus.yml: Cover SPICE in the MSYS2 job
Date: Wed, 22 Mar 2023 13:26:24 +0100	[thread overview]
Message-ID: <102b1198-9995-25da-2d49-1dcd11df558f@redhat.com> (raw)
In-Reply-To: <133c2b45-452c-c9e7-7fc4-c07d31d94298@linaro.org>

On 22/03/2023 13.13, Philippe Mathieu-Daudé wrote:
> On 22/3/23 12:30, Thomas Huth wrote:
>> On 22/03/2023 12.05, Philippe Mathieu-Daudé wrote:
>>> Include the mingw-w64-x86_64-spice package so SPICE is covered:
>>>
>>>    C compiler for the host machine: cc -m64 -mcx16 (gcc 12.2.0 "cc 
>>> (Rev10, Built by MSYS2 project) 12.2.0")
>>>    ...
>>>    Run-time dependency spice-protocol found: YES 0.14.4
>>>    Run-time dependency spice-server found: YES 0.15.1
>>>
>>> In particular this would have helped catching the build issue
>>> reported as https://gitlab.com/qemu-project/qemu/-/issues/1553:
>>
>> Well, hardly anybody is looking at the output on cirrus-ci.com, so this 
>> patch here likely would not have prevented the merging of this bug... for 
>> that, you rather have to add it to .gitlab-ci.d/windows.yml instead.
> 
> It seems we have 2 jobs doing the same testing (even same version,
> msys2-base-x86_64-20220603.sfx.exe). Does it make sense to maintain
> both? At least with GitLab we notice a failure.

We can test more things (targets) in the Cirrus-CI job since the build 
machines are way more powerful there ... but yes, since people rarely look 
at this output, it's maybe better to disable them and focus on the gitlab-CI 
jobs instead.

  Thomas



      parent reply	other threads:[~2023-03-22 12:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 11:05 [PATCH] cirrus.yml: Cover SPICE in the MSYS2 job Philippe Mathieu-Daudé
2023-03-22 11:30 ` Thomas Huth
2023-03-22 12:13   ` Philippe Mathieu-Daudé
2023-03-22 12:21     ` Daniel P. Berrangé
2023-03-22 12:26     ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=102b1198-9995-25da-2d49-1dcd11df558f@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=bin.meng@windriver.com \
    --cc=luoyonggang@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=nicememory@gmail.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).