From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>,
Anup Patel <anup.patel@wdc.com>,
Alistair Francis <Alistair.Francis@wdc.com>
Cc: Frederik Du Toit Lotter <fred.lotter@canonical.com>,
qemu-riscv@nongnu.org, qemu-devel@nongnu.org,
qemu-stable@nongnu.org
Subject: Re: [PATCH v2 1/1] goldfish_rtc: keep time offset when resetting
Date: Mon, 31 Mar 2025 16:16:10 +0200 [thread overview]
Message-ID: <102ba955-61c4-437b-b535-55e1c93b435f@linaro.org> (raw)
In-Reply-To: <20250321221248.17764-1-heinrich.schuchardt@canonical.com>
On 21/3/25 23:12, Heinrich Schuchardt wrote:
> Currently resetting the leads to resynchronizing the Goldfish RTC with the
> system clock of the host. In real hardware an RTC reset would not change
> the wall time. Other RTCs like pl031 do not show this behavior.
>
> Move the synchronization of the RTC with the system clock to the instance
> realization.
>
> Cc: qemu-stable@nongnu.org
> Reported-by: Frederik Du Toit Lotter <fred.lotter@canonical.com>
> Fixes: 9a5b40b8427 ("hw: rtc: Add Goldfish RTC device")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> v2:
> Remove a superfluous intialization to nul.
> Add Cc:, Fixes:, and Reviewed-by: tags.
> v1:
> https://lore.kernel.org/qemu-devel/CAAhSdy0-we9B19wRRqk_rRFkjY2LPPMRGaTdE=_4Ge_pCR4Y4Q@mail.gmail.com/T/
> ---
> hw/rtc/goldfish_rtc.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
Thanks, patch queued!
prev parent reply other threads:[~2025-03-31 14:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-21 22:12 [PATCH v2 1/1] goldfish_rtc: keep time offset when resetting Heinrich Schuchardt
2025-03-31 14:16 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=102ba955-61c4-437b-b535-55e1c93b435f@linaro.org \
--to=philmd@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=anup.patel@wdc.com \
--cc=fred.lotter@canonical.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).