From: Paolo Bonzini <pbonzini@redhat.com>
To: Peng Hao <peng.hao2@zte.com.cn>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/watchdog/wdt_i6300esb : remove a unnecessary comment
Date: Mon, 10 Dec 2018 18:17:30 +0100 [thread overview]
Message-ID: <103eeca6-0af2-da88-fa17-d09466d29ba8@redhat.com> (raw)
In-Reply-To: <1544253511-82742-1-git-send-email-peng.hao2@zte.com.cn>
On 08/12/18 08:18, Peng Hao wrote:
> The registered memory region of i6300esb is not suitable for coalesced
> mmio, because a write for the region may trigger an immediate action
> and can't be delayed.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
> hw/watchdog/wdt_i6300esb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c
> index 7b59469..1c6eddf 100644
> --- a/hw/watchdog/wdt_i6300esb.c
> +++ b/hw/watchdog/wdt_i6300esb.c
> @@ -449,7 +449,6 @@ static void i6300esb_realize(PCIDevice *dev, Error **errp)
> memory_region_init_io(&d->io_mem, OBJECT(d), &i6300esb_ops, d,
> "i6300esb", 0x10);
> pci_register_bar(&d->dev, 0, 0, &d->io_mem);
> - /* qemu_register_coalesced_mmio (addr, 0x10); ? */
> }
>
> static void i6300esb_exit(PCIDevice *dev)
>
Queued, thanks.
Paolo
prev parent reply other threads:[~2018-12-10 17:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-08 7:18 [Qemu-devel] [PATCH] hw/watchdog/wdt_i6300esb : remove a unnecessary comment Peng Hao
2018-12-10 17:17 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=103eeca6-0af2-da88-fa17-d09466d29ba8@redhat.com \
--to=pbonzini@redhat.com \
--cc=peng.hao2@zte.com.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).