* [Qemu-devel] [PATCH] hw/watchdog/wdt_i6300esb : remove a unnecessary comment
@ 2018-12-08 7:18 Peng Hao
2018-12-10 17:17 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Peng Hao @ 2018-12-08 7:18 UTC (permalink / raw)
To: pbonzini; +Cc: qemu-devel, Peng Hao
The registered memory region of i6300esb is not suitable for coalesced
mmio, because a write for the region may trigger an immediate action
and can't be delayed.
Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
hw/watchdog/wdt_i6300esb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c
index 7b59469..1c6eddf 100644
--- a/hw/watchdog/wdt_i6300esb.c
+++ b/hw/watchdog/wdt_i6300esb.c
@@ -449,7 +449,6 @@ static void i6300esb_realize(PCIDevice *dev, Error **errp)
memory_region_init_io(&d->io_mem, OBJECT(d), &i6300esb_ops, d,
"i6300esb", 0x10);
pci_register_bar(&d->dev, 0, 0, &d->io_mem);
- /* qemu_register_coalesced_mmio (addr, 0x10); ? */
}
static void i6300esb_exit(PCIDevice *dev)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] hw/watchdog/wdt_i6300esb : remove a unnecessary comment
2018-12-08 7:18 [Qemu-devel] [PATCH] hw/watchdog/wdt_i6300esb : remove a unnecessary comment Peng Hao
@ 2018-12-10 17:17 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2018-12-10 17:17 UTC (permalink / raw)
To: Peng Hao; +Cc: qemu-devel
On 08/12/18 08:18, Peng Hao wrote:
> The registered memory region of i6300esb is not suitable for coalesced
> mmio, because a write for the region may trigger an immediate action
> and can't be delayed.
>
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
> hw/watchdog/wdt_i6300esb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/watchdog/wdt_i6300esb.c b/hw/watchdog/wdt_i6300esb.c
> index 7b59469..1c6eddf 100644
> --- a/hw/watchdog/wdt_i6300esb.c
> +++ b/hw/watchdog/wdt_i6300esb.c
> @@ -449,7 +449,6 @@ static void i6300esb_realize(PCIDevice *dev, Error **errp)
> memory_region_init_io(&d->io_mem, OBJECT(d), &i6300esb_ops, d,
> "i6300esb", 0x10);
> pci_register_bar(&d->dev, 0, 0, &d->io_mem);
> - /* qemu_register_coalesced_mmio (addr, 0x10); ? */
> }
>
> static void i6300esb_exit(PCIDevice *dev)
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-10 17:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-08 7:18 [Qemu-devel] [PATCH] hw/watchdog/wdt_i6300esb : remove a unnecessary comment Peng Hao
2018-12-10 17:17 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).