qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Greg Kurz <groug@kaod.org>, QEMU Developers <qemu-devel@nongnu.org>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
	"Cédric Le Goater" <clg@kaod.org>,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: hw/intc/xics.c:605: ics_realize: Assertion `ics->xics' failed
Date: Tue, 7 Jul 2020 13:01:54 +0200	[thread overview]
Message-ID: <104a1848-4686-0b6f-fb0c-e09e2ffbd031@redhat.com> (raw)


 Hi Greg,

I just ran  scripts/device-crash-test and it triggered the assert that
you've added in commit b015a9809427c8 ("xics: Link ICS_PROP_XICS
property to ICSState::xics pointer"):

$ qemu-system-ppc64 -S -M powernv9,accel=tcg -device pnv-psi-POWER8
qemu-system-ppc64: hw/intc/xics.c:605: ics_realize: Assertion
`ics->xics' failed.
Aborted (core dumped)

That's ugly. Could you please have a look how this could be done in a
nicer way? (Maybe set errp and return in that case?)

 Thanks,
  Thomas



             reply	other threads:[~2020-07-07 11:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 11:01 Thomas Huth [this message]
2020-07-07 14:11 ` hw/intc/xics.c:605: ics_realize: Assertion `ics->xics' failed Greg Kurz
2020-07-07 15:31   ` Greg Kurz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=104a1848-4686-0b6f-fb0c-e09e2ffbd031@redhat.com \
    --to=thuth@redhat.com \
    --cc=clg@kaod.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).