From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24CB7C2D0E4 for ; Fri, 20 Nov 2020 16:27:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 952C92225B for ; Fri, 20 Nov 2020 16:27:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tT/IFJOI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 952C92225B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kg9Fh-0008Pk-FK for qemu-devel@archiver.kernel.org; Fri, 20 Nov 2020 11:27:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34586) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kg9DY-0006r6-Q5; Fri, 20 Nov 2020 11:25:00 -0500 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]:38155) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kg9DV-00067k-J3; Fri, 20 Nov 2020 11:25:00 -0500 Received: by mail-pf1-x434.google.com with SMTP id 10so8331053pfp.5; Fri, 20 Nov 2020 08:24:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=oIlBGux0NHQ0QgXRaRHRYv+1fIYxjg8pCsgUppiMSgg=; b=tT/IFJOIAjWRO0lnn+qQtsqMPCuNwLiVDf4GD0h+IwG5cVuWmYYAOvIETiN8jPn/L9 GKOqZOkpvbcpH4xW8MWptfZySxYLv3cjd6t3Y3VAClEREczLo1vmRhWnrZucGNQH9zcM zF7aES1U9BW6VxUoAPJ0DCK3cG5fC3k+K3MY4hVwSQb0IQoYxpdT7hK659FaUaLPtkrU KmDnERNcCjCacBugrQxh2Q7aYlNMk2t2963ll0ippgcF7gaymmxa+bOAc747ng47UE3L QELkFP75sc2mrtQSn50J6Jpv9RJ3TwFiT9q/Bq1Aj+QTAPT9mX13tvL2A0eZP+G0b1ib o4Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oIlBGux0NHQ0QgXRaRHRYv+1fIYxjg8pCsgUppiMSgg=; b=Zyd7cFzT8lN2BkAjYa379zRCVIZbv/fi4KJnjkIurOCPRhFAwRgQPQYFWp6Z/Ki/lr 1/gBsbcM6h/CaXNdFzBLA/ApgcCLi1aSMUO2wBq3on9X5BHJQpihKNMzOPUW2W85oBbQ p0WEn8BLu8Lwvw3abOuZUXxrhH6Zuicvt3MKjHKPY1rOFcYivNVU0CqdCADdntern9Z4 gFytvpralKh4NnvVp4F87pxgGKTAZBZmJdECYX7Qq6pW1OMAmtrulu0puCOxWpIqQO0T UFOy4BTQarB64SQ9HouKL9BZa28B+lU285t0vUbo73mP3DaLUxaQ2+P87ielfwJFAT8C oxDA== X-Gm-Message-State: AOAM531QGWi1SxrgYJshrW00qxoX5s8Zbm84fENoa5Q5rES1uQsd84UD 6PX4CGaOiGDmjg7VZsVHhLg= X-Google-Smtp-Source: ABdhPJzgfNMuERVO0RcrmMY/BXPSjT4C9C21MHxN221I8AK4QjNfqmk7Z9lDbE3QzFDu835Qwp0WXw== X-Received: by 2002:a63:4450:: with SMTP id t16mr17289795pgk.312.1605889495724; Fri, 20 Nov 2020 08:24:55 -0800 (PST) Received: from ?IPv6:2601:646:8e00:d1:6186:da9e:f87e:4f7c? ([2601:646:8e00:d1:6186:da9e:f87e:4f7c]) by smtp.gmail.com with ESMTPSA id 92sm4553587pjv.32.2020.11.20.08.24.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Nov 2020 08:24:54 -0800 (PST) Subject: Re: [RFC 15/15] target/riscv: rvb: support and turn on B-extension from command line To: Kito Cheng , frank.chang@sifive.com References: <20201118083044.13992-1-frank.chang@sifive.com> <20201118083044.13992-16-frank.chang@sifive.com> From: Alistair Francis Message-ID: <104fea2e-5c9a-8331-b9f5-4d5967651427@gmail.com> Date: Fri, 20 Nov 2020 08:24:51 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::434; envelope-from=alistair23@gmail.com; helo=mail-pf1-x434.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-riscv@nongnu.org, Sagar Karandikar , Bastian Koppelmann , qemu-devel@nongnu.org, Alistair Francis , Palmer Dabbelt Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 19/11/2020 7:02 pm, Kito Cheng wrote: >> diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c >> index 0bbfd7f4574..bc29e118c6d 100644 >> --- a/target/riscv/cpu.c >> +++ b/target/riscv/cpu.c >> @@ -438,6 +438,9 @@ static void riscv_cpu_realize(DeviceState *dev, Error **errp) >> if (cpu->cfg.ext_h) { >> target_misa |= RVH; >> } >> + if (cpu->cfg.ext_b) { >> + target_misa |= RVB; >> + } >> if (cpu->cfg.ext_v) { >> target_misa |= RVV; >> if (!is_power_of_2(cpu->cfg.vlen)) { >> @@ -515,6 +518,7 @@ static Property riscv_cpu_properties[] = { >> DEFINE_PROP_BOOL("s", RISCVCPU, cfg.ext_s, true), >> DEFINE_PROP_BOOL("u", RISCVCPU, cfg.ext_u, true), >> /* This is experimental so mark with 'x-' */ >> + DEFINE_PROP_BOOL("x-b", RISCVCPU, cfg.ext_b, true), > > I think the default value should be false? Good catch, I missed that. Yes it should be false. Alistair > >> DEFINE_PROP_BOOL("x-h", RISCVCPU, cfg.ext_h, false), >> DEFINE_PROP_BOOL("x-v", RISCVCPU, cfg.ext_v, false), >> DEFINE_PROP_BOOL("Counters", RISCVCPU, cfg.ext_counters, true), >