* [Qemu-devel] [PATCH resend] tests: Makefile: include dependency files
@ 2012-07-18 17:22 Eduardo Habkost
2012-07-24 11:16 ` Paolo Bonzini
2012-07-28 12:15 ` Blue Swirl
0 siblings, 2 replies; 3+ messages in thread
From: Eduardo Habkost @ 2012-07-18 17:22 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Anthony Liguori
Otherwise 'make check' won't recompile files that need to be recompiled
because of header changes.
To reproduce the bug, run:
$ make check # succeeds
$ echo B0RKED > hw/mc146818rtc_regs.h
$ make check # is supposed to try to rebuild tests/rtc-test.o and fail
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
tests/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/Makefile b/tests/Makefile
index d66ab19..b3f7494 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -143,3 +143,5 @@ check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS))
check-unit: $(patsubst %,check-%, $(check-unit-y))
check-block: $(patsubst %,check-%, $(check-block-y))
check: check-unit check-qtest
+
+-include $(wildcard tests/*.d)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH resend] tests: Makefile: include dependency files
2012-07-18 17:22 [Qemu-devel] [PATCH resend] tests: Makefile: include dependency files Eduardo Habkost
@ 2012-07-24 11:16 ` Paolo Bonzini
2012-07-28 12:15 ` Blue Swirl
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2012-07-24 11:16 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: qemu-devel, Anthony Liguori
----- Messaggio originale -----
> Da: "Eduardo Habkost" <ehabkost@redhat.com>
> A: qemu-devel@nongnu.org
> Cc: "Paolo Bonzini" <pbonzini@redhat.com>, "Anthony Liguori" <anthony@codemonkey.ws>
> Inviato: Mercoledì, 18 luglio 2012 19:22:27
> Oggetto: [PATCH resend] tests: Makefile: include dependency files
>
> Otherwise 'make check' won't recompile files that need to be
> recompiled
> because of header changes.
>
> To reproduce the bug, run:
>
> $ make check # succeeds
> $ echo B0RKED > hw/mc146818rtc_regs.h
> $ make check # is supposed to try to rebuild tests/rtc-test.o and
> fail
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> tests/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index d66ab19..b3f7494 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -143,3 +143,5 @@ check-qtest: $(patsubst %,check-qtest-%,
> $(QTEST_TARGETS))
> check-unit: $(patsubst %,check-%, $(check-unit-y))
> check-block: $(patsubst %,check-%, $(check-block-y))
> check: check-unit check-qtest
> +
> +-include $(wildcard tests/*.d)
> --
> 1.7.10.4
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH resend] tests: Makefile: include dependency files
2012-07-18 17:22 [Qemu-devel] [PATCH resend] tests: Makefile: include dependency files Eduardo Habkost
2012-07-24 11:16 ` Paolo Bonzini
@ 2012-07-28 12:15 ` Blue Swirl
1 sibling, 0 replies; 3+ messages in thread
From: Blue Swirl @ 2012-07-28 12:15 UTC (permalink / raw)
To: Eduardo Habkost; +Cc: Paolo Bonzini, qemu-devel, Anthony Liguori
On Wed, Jul 18, 2012 at 5:22 PM, Eduardo Habkost <ehabkost@redhat.com> wrote:
> Otherwise 'make check' won't recompile files that need to be recompiled
> because of header changes.
>
> To reproduce the bug, run:
>
> $ make check # succeeds
> $ echo B0RKED > hw/mc146818rtc_regs.h
> $ make check # is supposed to try to rebuild tests/rtc-test.o and fail
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Thanks, applied.
> ---
> tests/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index d66ab19..b3f7494 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -143,3 +143,5 @@ check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS))
> check-unit: $(patsubst %,check-%, $(check-unit-y))
> check-block: $(patsubst %,check-%, $(check-block-y))
> check: check-unit check-qtest
> +
> +-include $(wildcard tests/*.d)
> --
> 1.7.10.4
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-28 12:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-18 17:22 [Qemu-devel] [PATCH resend] tests: Makefile: include dependency files Eduardo Habkost
2012-07-24 11:16 ` Paolo Bonzini
2012-07-28 12:15 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).