From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dW3ur-0001zh-Me for qemu-devel@nongnu.org; Fri, 14 Jul 2017 12:58:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dW3uo-0005gj-KJ for qemu-devel@nongnu.org; Fri, 14 Jul 2017 12:58:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47766) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dW3uo-0005gG-BK for qemu-devel@nongnu.org; Fri, 14 Jul 2017 12:58:06 -0400 Date: Fri, 14 Jul 2017 12:58:03 -0400 (EDT) From: Paolo Bonzini Message-ID: <1055983739.16609523.1500051483584.JavaMail.zimbra@redhat.com> In-Reply-To: <61a76ac4-23f9-7c99-92e5-8097516de2a9@amsat.org> References: <1499238885-26161-1-git-send-email-pbonzini@redhat.com> <1499238885-26161-23-git-send-email-pbonzini@redhat.com> <4f304a14-572d-2835-cb0e-9d93c1c6dece@redhat.com> <55c62a5d-2ac5-4a89-f20a-100b19f8b0e9@redhat.com> <61a76ac4-23f9-7c99-92e5-8097516de2a9@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 22/42] configure: factor out list of supported Xen/KVM/HAX targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Peter Maydell , Anthony PERARD , Stefano Stabellini , Alex =?utf-8?Q?Benn=C3=A9e?= , QEMU Developers ----- Original Message ----- > From: "Philippe Mathieu-Daud=C3=A9" > To: "Paolo Bonzini" , "Peter Maydell" > Cc: "Anthony PERARD" , "Stefano Stabellini" , "Alex Benn=C3=A9e" > , "QEMU Developers" > Sent: Friday, July 14, 2017 5:26:36 PM > Subject: Re: [Qemu-devel] [PULL 22/42] configure: factor out list of supp= orted Xen/KVM/HAX targets >=20 > what about this RFC series? > http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg02513.html Too late for 2.10, but the way to go is to define a new "xenpv" target. In fact, --disable-tcg was the prerequisite for that if I remember correctl= y my old discussions with Citrix folks (could it have been Wei Liu?) Paolo > On 07/10/2017 01:28 PM, Paolo Bonzini wrote: > > On 10/07/2017 18:24, Peter Maydell wrote: > >> On 10 July 2017 at 17:14, Paolo Bonzini wrote: > >>> On 10/07/2017 17:49, Peter Maydell wrote: > >>>> On 5 July 2017 at 08:14, Paolo Bonzini wrote: > >>>>> This will be useful when the functions are called, early in the > >>>>> configure > >>>>> process, to filter out targets that do not support hardware > >>>>> acceleration. > >>>>> > >>>>> Signed-off-by: Paolo Bonzini > >>>> > >>>>> +supported_xen_target() { > >>>>> + test "$xen" =3D "yes" || return 1 > >>>>> + glob "$1" "*-softmmu" || return 1 > >>>>> + case "${1%-softmmu}:$cpu" in > >>>>> + arm:arm | aarch64:aarch64 | \ > >>>>> + i386:i386 | i386:x86_64 | x86_64:i386 | x86_64:x86_64) > >>>>> + return 0 > >>>>> + ;; > >>>> > >>>> This says that arm-on-arm and aarch64-on-aarch64 are supported > >>>> Xen targets... > >>> > >>> Hmm, this comes from my old patches. IIRC the reason for the change, > >>> when it wasn't a change (many conflicts ago) was that Xen folks were > >>> using --disable-tcg because their device model for Xen PV on ARM was > >>> actually an x86_64 QEMU. > >>> > >>> Stefano and Anthony, is this still true? If so, would it make sense = to > >>> add the Xen PV machine type to qemu-system-arm---that is, is it > >>> something you can whip up easily, or should I just remove that line? > >> > >> I think you should just fix configure for the moment, because > >> this patch wasn't supposed to change anything about what we > >> build (AIUI). We can think about changing the Xen PV on ARM > >> build setup as a separate thing if we want to, I suspect it > >> is more invasive than a couple of lines changing in configure. > >=20 > > Yes, definitely more invasive. > >=20 > > I'll prepare a fix. > >=20 > > Paolo > >=20 >=20