From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35939) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXZ9I-0001B8-L1 for qemu-devel@nongnu.org; Wed, 01 May 2013 11:40:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXZ9H-0008F5-G1 for qemu-devel@nongnu.org; Wed, 01 May 2013 11:40:52 -0400 Received: from mx3-phx2.redhat.com ([209.132.183.24]:36044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXZ9G-0008Es-NQ for qemu-devel@nongnu.org; Wed, 01 May 2013 11:40:51 -0400 Date: Wed, 1 May 2013 11:40:45 -0400 (EDT) From: Paolo Bonzini Message-ID: <1062403018.4755871.1367422845697.JavaMail.root@redhat.com> In-Reply-To: <51810F9D.3000605@hp.com> References: <1367410972-22972-1-git-send-email-chegu_vinod@hp.com> <51810CC0.2080407@redhat.com> <51810F9D.3000605@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] Throttle-down guest when live migration does not converge. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chegu Vinod Cc: owasserm@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, quintela@redhat.com > I shall make the suggested changes. > Appreciate your review feedback on this part of the change. Hi Vinod, I think unfortunately it is not acceptable to make this patch work only for KVM. (It cannot work for Xen, but that's not a problem since Xen uses a different migration mechanism; but it should work for TCG). Unfortunately, as you noted the run_on_cpu callbacks currently run under the big QEMU lock. We need to fix that first. We have time for that during 1.6. Paolo