From: Paolo Bonzini <pbonzini@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
Kevin Wolf <kwolf@redhat.com>, Andrew Jeffery <andrew@aj.id.au>,
QEMU Developers <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
qemu-arm <qemu-arm@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v4 5/5] tests: add a m25p80 test
Date: Tue, 28 Jun 2016 07:43:37 -0400 (EDT) [thread overview]
Message-ID: <1065775744.2615831.1467114217903.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <ea6a1789-9c82-e3d7-6c82-0f26817bbb34@kaod.org>
----- Original Message -----
> From: "Cédric Le Goater" <clg@kaod.org>
> To: "Peter Maydell" <peter.maydell@linaro.org>
> Cc: "Paolo Bonzini" <pbonzini@redhat.com>, "Peter Crosthwaite" <crosthwaite.peter@gmail.com>, "Kevin Wolf"
> <kwolf@redhat.com>, "Andrew Jeffery" <andrew@aj.id.au>, "QEMU Developers" <qemu-devel@nongnu.org>, "Markus
> Armbruster" <armbru@redhat.com>, "qemu-arm" <qemu-arm@nongnu.org>
> Sent: Tuesday, June 28, 2016 10:40:15 AM
> Subject: Re: [PATCH v4 5/5] tests: add a m25p80 test
>
> On 06/28/2016 10:34 AM, Peter Maydell wrote:
> > On 28 June 2016 at 09:32, Cédric Le Goater <clg@kaod.org> wrote:
> >> On 06/28/2016 10:01 AM, Paolo Bonzini wrote:
> >>>
> >>>
> >>> On 27/06/2016 18:43, Cédric Le Goater wrote:
> >>>> check-qtest-arm-y = tests/ds1338-test$(EXESUF)
> >>>> +check-qtest-arm-y = tests/m25p80-test$(EXESUF)
> >>>
> >>> This should be a "+=".
> >>
> >> OK. I will fix the above line also then :
> >>
> >> check-qtest-arm-y = tests/tmp105-test$(EXESUF)
> >> check-qtest-arm-y = tests/ds1338-test$(EXESUF)
> >
> > That's fixed in master.
>
> OK. The patchset needs a rebase now that Marcin's patches are in.
Please include my patches too, since otherwise the test is broken.
Thanks,
Paolo
next prev parent reply other threads:[~2016-06-28 11:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 16:43 [Qemu-devel] [PATCH v4 0/5] ast2400: SMC controllers Cédric Le Goater
2016-06-27 16:43 ` [Qemu-devel] [PATCH v4 1/5] m25p80: qdev-ify drive property Cédric Le Goater
2016-06-27 16:43 ` [Qemu-devel] [PATCH v4 2/5] ast2400: add SMC controllers (FMC and SPI) Cédric Le Goater
2016-06-27 16:43 ` [Qemu-devel] [PATCH v4 3/5] ast2400: add SPI flash slaves Cédric Le Goater
2016-06-27 16:43 ` [Qemu-devel] [PATCH v4 4/5] ast2400: create " Cédric Le Goater
2016-06-27 16:43 ` [Qemu-devel] [PATCH v4 5/5] tests: add a m25p80 test Cédric Le Goater
2016-06-28 5:46 ` Cédric Le Goater
2016-06-28 8:01 ` Paolo Bonzini
2016-06-28 8:32 ` Cédric Le Goater
2016-06-28 8:34 ` Peter Maydell
2016-06-28 8:40 ` Cédric Le Goater
2016-06-28 11:43 ` Paolo Bonzini [this message]
2016-06-28 8:03 ` Paolo Bonzini
2016-06-28 8:29 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1065775744.2615831.1467114217903.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=andrew@aj.id.au \
--cc=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=crosthwaite.peter@gmail.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).