From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MI5qR-0006QJ-19 for qemu-devel@nongnu.org; Sat, 20 Jun 2009 15:03:19 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MI5qL-0006Pf-Ln for qemu-devel@nongnu.org; Sat, 20 Jun 2009 15:03:17 -0400 Received: from [199.232.76.173] (port=36206 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MI5qL-0006Pc-F3 for qemu-devel@nongnu.org; Sat, 20 Jun 2009 15:03:13 -0400 Received: from smtp2-g21.free.fr ([212.27.42.2]:38381) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MI5qK-0000yA-IG for qemu-devel@nongnu.org; Sat, 20 Jun 2009 15:03:13 -0400 In-Reply-To: <4A3D3189.1080307@redhat.com> Subject: Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC From: "=?utf-8?q?Fran=C3=A7ois?= Revol" Date: Sat, 20 Jun 2009 21:03:02 +0200 CEST Message-Id: <10665282192-BeMail@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: programmingkidx@gmail.com, qemu-devel@nongnu.org > On 06/20/2009 05:31 PM, Anthony Liguori wrote: > > Please include a Signed-off-by line and use C-style comments > > instead > > of C++ style comments. Otherwise, looks good. > > What do we have against C++ style comments=3F They are not valid in C code :P Fran=C3=A7ois.