From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Guenter Roeck <linux@roeck-us.net>,
Peter Maydell <peter.maydell@linaro.org>
Cc: Beniamino Galvani <b.galvani@gmail.com>,
Niek Linnenbank <nieklinnenbank@gmail.com>,
qemu-arm@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 0/3] arm: allwinner: Wire up USB ports
Date: Tue, 18 Feb 2020 07:39:52 +0100 [thread overview]
Message-ID: <1069ca0c-2902-1c76-d111-de6c6129b02b@redhat.com> (raw)
In-Reply-To: <20200217204812.9857-1-linux@roeck-us.net>
Cc'ing Niek.
On 2/17/20 9:48 PM, Guenter Roeck wrote:
> Instantiate EHCI and OHCI controllers on Allwinner A10.
>
> The first patch in the series moves the declaration of EHCISysBusState
> from hcd-ohci.c to hcd-ohci.h. This lets us add the structure to
> AwA10State. Similar, TYPE_SYSBUS_OHCI is moved to be able to use it
> outside its driver.
>
> The second patch introduces the ehci-sysbus property "companion-enable".
> This lets us use object_property_set_bool() to enable companion mode.
>
> The third patch instantiates EHCI and OHCI ports for Allwinner-A10
> and marks the OHCI ports as companions of the respective EHCI ports.
>
> Tested by attaching various high speed and full speed devices, and by
> booting from USB drive.
>
> v3: Rebased to master
> v2: Add summary
> Rewrite to instantiate OHCI in companion mode; add patch 2/3
> Merge EHCI and OHCI instantiation into a single patch
>
> ----------------------------------------------------------------
> Guenter Roeck (3):
> hw: usb: hcd-ohci: Move OHCISysBusState and TYPE_SYSBUS_OHCI to include file
> hcd-ehci: Introduce "companion-enable" sysbus property
> arm: allwinner: Wire up USB ports
>
> hw/arm/allwinner-a10.c | 43 ++++++++++++++++++++++++++++++++++++++++++
> hw/usb/hcd-ehci-sysbus.c | 2 ++
> hw/usb/hcd-ohci.c | 15 ---------------
> hw/usb/hcd-ohci.h | 16 ++++++++++++++++
> include/hw/arm/allwinner-a10.h | 6 ++++++
> 5 files changed, 67 insertions(+), 15 deletions(-)
>
next prev parent reply other threads:[~2020-02-18 6:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 20:48 [PATCH v3 0/3] arm: allwinner: Wire up USB ports Guenter Roeck
2020-02-17 20:48 ` [PATCH v3 1/3] hw: usb: hcd-ohci: Move OHCISysBusState and TYPE_SYSBUS_OHCI to include file Guenter Roeck
2020-02-17 20:48 ` [PATCH v3 2/3] hcd-ehci: Introduce "companion-enable" sysbus property Guenter Roeck
2020-02-17 20:48 ` [PATCH v3 3/3] arm: allwinner: Wire up USB ports Guenter Roeck
2020-02-18 6:39 ` Philippe Mathieu-Daudé [this message]
2020-02-18 22:32 ` [PATCH v3 0/3] " Niek Linnenbank
2020-02-20 14:50 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1069ca0c-2902-1c76-d111-de6c6129b02b@redhat.com \
--to=philmd@redhat.com \
--cc=b.galvani@gmail.com \
--cc=kraxel@redhat.com \
--cc=linux@roeck-us.net \
--cc=nieklinnenbank@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).