Re: [Qemu-devel] [PATCH v5 12/21] vhost-user: document migration log

["Marc-André Lureau" <mlureau@redhat.com>]

Hi

----- Original Message -----
> On 09/24/2015 10:22 AM, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > 
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> >  docs/specs/vhost-user.txt | 48
> >  +++++++++++++++++++++++++++++++++++++++++++++--
> >  1 file changed, 46 insertions(+), 2 deletions(-)
> 
> > @@ -140,8 +142,7 @@ Multiple queue support
> >  
> >  Multiple queue is treated as a protocol extension, hence the slave has to
> >  implement protocol features first. The multiple queues feature is
> >  supported
> > -only when the protocol feature VHOST_USER_PROTOCOL_F_MQ (bit 0) is set:
> > -#define VHOST_USER_PROTOCOL_F_MQ    0
> > +only when the protocol feature VHOST_USER_PROTOCOL_F_MQ (bit 0) is set.
> 
> Should this hunk be in an earlier patch,

The series is on top of last Michael PULL request. I just moved the define
in a common section, since now they are 2 and later 3. Does that make sense?

> 
> > +
> > +Protocol features
> > +-----------------
> > +
> > +#define VHOST_USER_PROTOCOL_F_MQ             0
> > +#define VHOST_USER_PROTOCOL_F_LOG_SHMFD      1
> 
> along with this section (of course, with just bit 0 in that patch)?
> 
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 
>