From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L2CY5-0005Mr-G1
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:26:25 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L2CY4-0005Mb-0V
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:26:25 -0500
Received: from [199.232.76.173] (port=37696 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L2CY3-0005MY-RI
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:26:23 -0500
Received: from smtp4-g19.free.fr ([212.27.42.30]:44643)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <revol@free.fr>) id 1L2CY3-0006k6-MA
	for qemu-devel@nongnu.org; Mon, 17 Nov 2008 17:26:23 -0500
Received: from smtp4-g19.free.fr (localhost.localdomain [127.0.0.1])
	by smtp4-g19.free.fr (Postfix) with ESMTP id A97A53EA0F4
	for <qemu-devel@nongnu.org>; Mon, 17 Nov 2008 23:26:22 +0100 (CET)
Received: from laptop (vaf26-2-82-244-111-82.fbx.proxad.net [82.244.111.82])
	by smtp4-g19.free.fr (Postfix) with ESMTP id 8339B3EA0D2
	for <qemu-devel@nongnu.org>; Mon, 17 Nov 2008 23:26:22 +0100 (CET)
In-Reply-To: <20081117220709.GA20874@game.jcrosoft.org>
Subject: Re: [Qemu-devel] [PATCH 2/4] uImage: implement gzip support
From: "=?windows-1252?q?Fran=E7ois?= Revol" <revol@free.fr>
Date: Mon, 17 Nov 2008 23:30:53 +0100 CET
Message-Id: <10837025566-BeMail@laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

> > -    /* TODO: Implement compressed images.  */
> > -    if (hdr->ih=5Fcomp !=3D IH=5FCOMP=5FNONE) {
> > -        fprintf(stderr, "Unable to load compressed u-boot images\
> > n");
> > +    /* TODO bzip2 support */
> > +    if (hdr->ih=5Fcomp =3D=3D IH=5FCOMP=5FBZIP2) {
> > +        fprintf(stderr, "Unable to load bzip2 compressed u-boot 
> > images\n");
> >          goto fail;
> >      }
> why do you remove the non compress mode=3F

He didn't remove it, he changed the check to only reject BZIP2, not 
uncompressed (which is wrong though as it'd accept any other compession 
including unknown).

> BTW Please note 2 thinks
> First this format of uImage is deprecated
> we have switch to a fdt uImage format

fdt =3F as in flat device tree =3F
Is that documented somewhere =3F
I'll need to add U-Boot support to Haiku soon...

Fran=E7ois.