From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDxBK-0003Jd-L5 for qemu-devel@nongnu.org; Fri, 17 Jun 2016 13:03:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDxBJ-0000WQ-Mj for qemu-devel@nongnu.org; Fri, 17 Jun 2016 13:03:46 -0400 References: <1466181227-14934-1-git-send-email-alex.bennee@linaro.org> <1466181227-14934-2-git-send-email-alex.bennee@linaro.org> From: Paolo Bonzini Message-ID: <1083a5ee-1898-391d-9d08-d65a30bf8a6d@redhat.com> Date: Fri, 17 Jun 2016 19:03:30 +0200 MIME-Version: 1.0 In-Reply-To: <1466181227-14934-2-git-send-email-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC 1/7] cpu: move break/watchpoints into arrays. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , mttcg@greensocs.com, qemu-devel@nongnu.org, fred.konrad@greensocs.com, a.rigo@virtualopensystems.com, serge.fdrv@gmail.com, cota@braap.org, bobby.prani@gmail.com Cc: mark.burton@greensocs.com, jan.kiszka@siemens.com, rth@twiddle.net, peter.maydell@linaro.org, claudio.fontana@huawei.com, Peter Crosthwaite , Riku Voipio , Eduardo Habkost , Michael Walle , "open list:ARM" On 17/06/2016 18:33, Alex Benn=C3=A9e wrote: > Before we can protect the lists we need a structure a little more > amenable to RCU protection. This moves all the lists into a re-sizeable > array. The array still only points to allocated structures because a > number of the architectures still need to look at the results of a hit > by examining the field. >=20 > Signed-off-by: Alex Benn=C3=A9e > --- > cpu-exec.c | 6 +- > exec.c | 167 ++++++++++++++++++++++++++++++-------= -------- Can you look into moving this to cpu-exec.c? (or cpu-exec-common.c perhaps?) It's TCG only, so it doesn't really belong in exec.c if we can help it. Paolo > include/qom/cpu.h | 22 +++--- > linux-user/main.c | 22 +++--- > qom/cpu.c | 2 - > target-arm/translate-a64.c | 6 +- > target-arm/translate.c | 6 +- > target-i386/bpt_helper.c | 6 +- > target-lm32/helper.c | 6 +- > 9 files changed, 157 insertions(+), 86 deletions(-)