From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 1/2] qapi: change QmpOutputVisitor to QSLIST
Date: Thu, 7 Jul 2016 12:44:23 -0400 (EDT) [thread overview]
Message-ID: <1084721995.4983100.1467909863450.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <87twg1fm52.fsf@dusky.pond.sub.org>
> > struct QmpOutputVisitor
> > {
> > Visitor visitor;
> > - QStack stack; /* Stack of containers that haven't yet been finished */
> > + QSLIST_HEAD(, QStackEntry) stack; /* Stack of containers that haven't
> > yet been finished */
>
> Long line. I'll squash in Eric's proposed fix on commit if you don't
> mind:
>
> QSLIST_HEAD(...); /* Stack of unfinished containers */
Yes, of course, sorry for forgetting about it.
Paolo
next prev parent reply other threads:[~2016-07-07 16:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 15:53 [Qemu-devel] [PATCH v3 0/2] qapi: change QObject visitors to QSLIST Paolo Bonzini
2016-07-07 15:53 ` [Qemu-devel] [PATCH v3 1/2] qapi: change QmpOutputVisitor " Paolo Bonzini
2016-07-07 16:28 ` Markus Armbruster
2016-07-07 16:44 ` Paolo Bonzini [this message]
2016-07-08 6:56 ` Markus Armbruster
2016-07-07 15:53 ` [Qemu-devel] [PATCH v3 2/2] qapi: change QmpInputVisitor " Paolo Bonzini
2016-07-07 18:30 ` Eric Blake
2016-07-07 16:29 ` [Qemu-devel] [PATCH v3 0/2] qapi: change QObject visitors " Markus Armbruster
2016-07-08 7:24 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1084721995.4983100.1467909863450.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).