From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLCPd-0003hD-1H for qemu-devel@nongnu.org; Thu, 07 Jul 2016 12:44:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLCPY-0002qk-Sj for qemu-devel@nongnu.org; Thu, 07 Jul 2016 12:44:28 -0400 Received: from mx6-phx2.redhat.com ([209.132.183.39]:60155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLCPY-0002qS-KV for qemu-devel@nongnu.org; Thu, 07 Jul 2016 12:44:24 -0400 Date: Thu, 7 Jul 2016 12:44:23 -0400 (EDT) From: Paolo Bonzini Message-ID: <1084721995.4983100.1467909863450.JavaMail.zimbra@redhat.com> In-Reply-To: <87twg1fm52.fsf@dusky.pond.sub.org> References: <1467906798-5312-1-git-send-email-pbonzini@redhat.com> <1467906798-5312-2-git-send-email-pbonzini@redhat.com> <87twg1fm52.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/2] qapi: change QmpOutputVisitor to QSLIST List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org > > struct QmpOutputVisitor > > { > > Visitor visitor; > > - QStack stack; /* Stack of containers that haven't yet been finished */ > > + QSLIST_HEAD(, QStackEntry) stack; /* Stack of containers that haven't > > yet been finished */ > > Long line. I'll squash in Eric's proposed fix on commit if you don't > mind: > > QSLIST_HEAD(...); /* Stack of unfinished containers */ Yes, of course, sorry for forgetting about it. Paolo