From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BPhyF-0006j9-Ed for qemu-devel@nongnu.org; Mon, 17 May 2004 09:15:55 -0400 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BPh6J-0007rJ-Da for qemu-devel@nongnu.org; Mon, 17 May 2004 08:20:44 -0400 Received: from [62.210.158.41] (helo=moscou.magic.fr) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BPg7i-0001Wt-0r for qemu-devel@nongnu.org; Mon, 17 May 2004 07:17:34 -0400 Received: from [10.0.0.2] (ppp-181.net-555.magic.fr [62.210.255.181]) by moscou.magic.fr (8.11.6/8.10.1) with ESMTP id i4HBHUl17338 for ; Mon, 17 May 2004 13:17:30 +0200 (CEST) Subject: Re: [Qemu-devel] portable to old compiler and kernel From: "J. Mayer" In-Reply-To: <40A88730.6000208@simtreas.ru> References: <200405161546.i4GFkHOR031617@treas.simtreas.ru> <40A88730.6000208@simtreas.ru> Content-Type: text/plain Message-Id: <1084792655.8247.6731.camel@rapid> Mime-Version: 1.0 Date: Mon, 17 May 2004 13:17:35 +0200 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Mon, 2004-05-17 at 11:34, Vladimir N. Oleynik wrote: > Hi. > Hello, > 3) hw/fdc.c > #define FLOPPY_ERROR(fmt, args...) \ > do { printf("FLOPPY ERROR: %s: " fmt, __func__ , ##args); } while (0) > to > #define FLOPPY_ERROR(fmt, args...) \ > do { printf("FLOPPY ERROR: %s: " fmt, __FUNCTION__ , ##args); } while (0) Don't do that. __func__ is ISO C, __FUNCTION__ isn't. You'd better add this somewhere: #if __GNUC__ <= 2 && __GNUC_MINOR__ < 95 #define __func__ __FUNCTION__ #endif which makes egcs happy and doesn't make gcc 3.xx warn about deprecated features. -- J. Mayer Never organized