From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1BbhlW-0002Ve-Qu
	for qemu-devel@nongnu.org; Sat, 19 Jun 2004 11:28:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1BbhlV-0002VQ-9t
	for qemu-devel@nongnu.org; Sat, 19 Jun 2004 11:28:22 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1BbhlV-0002VN-7x
	for qemu-devel@nongnu.org; Sat, 19 Jun 2004 11:28:21 -0400
Received: from [213.146.130.142] (helo=trantor.org.uk)
	by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168)
	(Exim 4.34) id 1BbhkI-00056l-Ko
	for qemu-devel@nongnu.org; Sat, 19 Jun 2004 11:27:06 -0400
Subject: Re: [Qemu-devel] [PATCH] security_20040618
From: Gianni Tedesco <gianni@scaramanga.co.uk>
In-Reply-To: <20040619151931.GC1962@sentinelchicken.org>
References: <20040618184036.GA1874@sentinelchicken.org>
	<1087636303.3375.200.camel@sherbert>
	<20040619151931.GC1962@sentinelchicken.org>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="=-Q0F3iu9ITnllsZFiMtta"
Date: Sat, 19 Jun 2004 16:26:08 +0100
Message-Id: <1087658769.3375.236.camel@sherbert>
Mime-Version: 1.0
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org


--=-Q0F3iu9ITnllsZFiMtta
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sat, 2004-06-19 at 08:19 -0700, Tim wrote:
> > In dyngen you need to do:
> >=20
> > if ( ptr =3D=3D NULL )
> > 	error("malloc failed");
> >=20
> > error() will never return.
> >
> > For the other places it depends, but it's ususally quite simple. Why no=
t
> > have a stab and submit a seperate patch on top of this one?
>=20
> You would prefer I submit a seperate patch for the malloc fixes?  I
> could certainly do that, but I just figured it is all a general code
> quality patch, which changes very few lines of code (though in many
> files).  What would you prefer Fabrice?

Well, I meant if you were to go ahead and implement all the TODOs and
handle all the malloc returns properly. I'd submit that as a seperate
patch, i mean, if you aren't 100% confident of your analyses.

--=20
// Gianni Tedesco (gianni at scaramanga dot co dot uk)
lynx --source www.scaramanga.co.uk/scaramanga.asc | gpg --import
8646BE7D: 6D9F 2287 870E A2C9 8F60 3A3C 91B5 7669 8646 BE7D

--=-Q0F3iu9ITnllsZFiMtta
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQBA1FsPkbV2aYZGvn0RArcWAJ4rFGzxS0dkBKbOtNBL+Ctl1mrGkACfVDRV
lnfonLzuy3rAZH9xXa3tLqc=
=QJqN
-----END PGP SIGNATURE-----

--=-Q0F3iu9ITnllsZFiMtta--