[Qemu-devel] [Patch] Darwin and qemu-system-ppc

[Qemu-devel] [Patch] Darwin and qemu-system-ppc

[Pierre d'Herbemont]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

Hi!

Here is a fix for Mac OS X/Darwin. You must define OPCODES_SECTION if 
you don't want to get the errorat launch time:
*** ERROR: opcode ff already assigned in main opcode table
*** ERROR initializing PPC instruction 0xff 0xff 0xff

Thank,

Pierre

[-- Attachment #2: translate_ppc.diff.txt --]
[-- Type: text/plain, Size: 619 bytes --]

Index: target-ppc/translate.c
===================================================================
RCS file: /cvsroot/qemu/qemu/target-ppc/translate.c,v
retrieving revision 1.20
diff -u -r1.20 translate.c
--- target-ppc/translate.c	10 Jul 2004 15:33:29 -0000	1.20
+++ target-ppc/translate.c	12 Jul 2004 12:16:52 -0000
@@ -279,6 +279,9 @@
 #if defined(__linux__)
 #define OPCODES_SECTION \
     __attribute__ ((section(".opcodes"), unused, aligned (8) ))
+#elif defined(__APPLE__)
+#define OPCODES_SECTION \
+    __attribute__ ((section("__TEXT,__opcodes"), unused, aligned (8) ))
 #else
 #define OPCODES_SECTION
 #endif

Re: [Qemu-devel] [Patch] Darwin and qemu-system-ppc

[Jocelyn Mayer]

On Mon, 2004-07-12 at 14:18, Pierre d'Herbemont wrote:
> Hi!
> 
> Here is a fix for Mac OS X/Darwin. You must define OPCODES_SECTION if 
> you don't want to get the errorat launch time:
> *** ERROR: opcode ff already assigned in main opcode table
> *** ERROR initializing PPC instruction 0xff 0xff 0xff

IMHO, this is an error to define it has nothing, as emulation won't run
in that case.
So it would be better to replace:

#else
#define OPCODES_SECTION
#endif

with:

#else
#error "OPCODE_SECTION isn't defined for this host OS"
#endif

-- 
Jocelyn Mayer <l_indien@magic.fr>
Never organized