[Qemu-devel] [PATCH] hw/ide.c and WIN_STANDBYNOW1

[Qemu-devel] [PATCH] hw/ide.c and WIN_STANDBYNOW1

[Magnus Damm]

[-- Attachment #1: Type: text/plain, Size: 1663 bytes --]

Hi,

This stupid little fix adds dummy support for WIN_STANDBYNOW1.
It is probably not the right way to do it, though.
I'm happy with it because it makes my linux-2.6 kernel shut up.

Thanks.

/ magnus - not subscribed, please cc

Here's output from linux-2.6.8-rc2 with/without the patch:

with patch:

/ # poweroff

The system is going down NOW !!
Sending SIGTERM to all processes.
Sending SIGKILL to all processes.
Shutdown: hda
Power down.


without patch:

/ # poweroff
 
The system is going down NOW !!
Sending SIGTERM to all processes.
Sending SIGKILL to all processes.
Shutdown: hda
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
ide0: reset: success
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
ide0: reset: success
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
Power down.


[-- Attachment #2: qemu-20040722-ide_WIN_STANDBYNOW.patch --]
[-- Type: text/x-patch, Size: 544 bytes --]

Index: hw/ide.c
===================================================================
RCS file: /cvsroot/qemu/qemu/hw/ide.c,v
retrieving revision 1.26
diff -u -r1.26 ide.c
--- hw/ide.c	25 Jun 2004 14:54:19 -0000	1.26
+++ hw/ide.c	21 Jul 2004 22:51:07 -0000
@@ -1567,6 +1567,10 @@
                 goto abort_cmd;
             }
             break;
+	case WIN_STANDBYNOW1:
+	    s->status = READY_STAT;
+            ide_set_irq(s);
+            break;
             /* ATAPI commands */
         case WIN_PIDENTIFY:
             if (s->is_cdrom) {