From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1BnQ1A-0004j2-In
	for qemu-devel@nongnu.org; Wed, 21 Jul 2004 18:56:56 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1BnQ19-0004iq-Mr
	for qemu-devel@nongnu.org; Wed, 21 Jul 2004 18:56:56 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1BnQ19-0004in-IV
	for qemu-devel@nongnu.org; Wed, 21 Jul 2004 18:56:55 -0400
Received: from [213.80.72.10] (helo=kubrik.opensource.se)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1BnPy6-0003Xa-Je
	for qemu-devel@nongnu.org; Wed, 21 Jul 2004 18:53:47 -0400
Received: from [192.168.1.16] (unknown [213.80.72.14])
	by kubrik.opensource.se (Postfix) with ESMTP id 34EAA3752C
	for <qemu-devel@nongnu.org>; Thu, 22 Jul 2004 00:42:03 +0200 (CEST)
From: Magnus Damm <damm@opensource.se>
Content-Type: multipart/mixed; boundary="=-ml7n/VgMqTEahfb5Z3rH"
Message-Id: <1090450785.14764.13.camel@kubu.opensource.se>
Mime-Version: 1.0
Date: Thu, 22 Jul 2004 00:59:45 +0200
Subject: [Qemu-devel] [PATCH] hw/ide.c and WIN_STANDBYNOW1
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org


--=-ml7n/VgMqTEahfb5Z3rH
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

Hi,

This stupid little fix adds dummy support for WIN_STANDBYNOW1.
It is probably not the right way to do it, though.
I'm happy with it because it makes my linux-2.6 kernel shut up.

Thanks.

/ magnus - not subscribed, please cc

Here's output from linux-2.6.8-rc2 with/without the patch:

with patch:

/ # poweroff

The system is going down NOW !!
Sending SIGTERM to all processes.
Sending SIGKILL to all processes.
Shutdown: hda
Power down.


without patch:

/ # poweroff
 
The system is going down NOW !!
Sending SIGTERM to all processes.
Sending SIGKILL to all processes.
Shutdown: hda
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
ide0: reset: success
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
ide0: reset: success
hda: task_no_data_intr: status=0x41 { DriveReady Error }
hda: task_no_data_intr: error=0x04 { DriveStatusError }
Power down.


--=-ml7n/VgMqTEahfb5Z3rH
Content-Disposition: attachment;
	filename=qemu-20040722-ide_WIN_STANDBYNOW.patch
Content-Type: text/x-patch; name=qemu-20040722-ide_WIN_STANDBYNOW.patch;
	charset=UTF-8
Content-Transfer-Encoding: 7bit

Index: hw/ide.c
===================================================================
RCS file: /cvsroot/qemu/qemu/hw/ide.c,v
retrieving revision 1.26
diff -u -r1.26 ide.c
--- hw/ide.c	25 Jun 2004 14:54:19 -0000	1.26
+++ hw/ide.c	21 Jul 2004 22:51:07 -0000
@@ -1567,6 +1567,10 @@
                 goto abort_cmd;
             }
             break;
+	case WIN_STANDBYNOW1:
+	    s->status = READY_STAT;
+            ide_set_irq(s);
+            break;
             /* ATAPI commands */
         case WIN_PIDENTIFY:
             if (s->is_cdrom) {

--=-ml7n/VgMqTEahfb5Z3rH--