From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1BuspG-0001sP-86
	for qemu-devel@nongnu.org; Wed, 11 Aug 2004 09:07:30 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1BuspD-0001s5-Kv
	for qemu-devel@nongnu.org; Wed, 11 Aug 2004 09:07:29 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1BuspD-0001rv-Eh
	for qemu-devel@nongnu.org; Wed, 11 Aug 2004 09:07:27 -0400
Received: from [62.253.162.44] (helo=mta04-svc.ntlworld.com)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1Busl0-00015k-8l
	for qemu-devel@nongnu.org; Wed, 11 Aug 2004 09:03:06 -0400
Received: from [10.10.10.100] ([81.107.87.144]) by mta04-svc.ntlworld.com
	(InterMail vM.4.01.03.37 201-229-121-137-20020806) with ESMTP
	id <20040811130144.QWUN575.mta04-svc.ntlworld.com@[10.10.10.100]>
	for <qemu-devel@nongnu.org>; Wed, 11 Aug 2004 14:01:44 +0100
Subject: Re: [Qemu-devel] Andrew Curtis' PCNet Patch built on MingW
From: Antony T Curtis <antony.t.curtis@ntlworld.com>
In-Reply-To: <76bfb9d2040811051758d52cce@mail.gmail.com>
References: <-3725715442654674811@unknownmsgid>
	<76bfb9d2040811051758d52cce@mail.gmail.com>
Content-Type: text/plain
Message-Id: <1092229383.83749.26.camel@pcgem.rdg.cyberkinetica.com>
Mime-Version: 1.0
Date: Wed, 11 Aug 2004 14:03:05 +0100
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, 2004-08-11 at 13:17, Garth Dahlstrom wrote:
> Antony T Curtis wrote:
> 
> > There is no such SWSTYLE as 0x04 on the PC-Net chip I emulated. You
> > should be able to safely ignore this message.
> >
> > maybe the PACKED name conflicts with some existing symbol if you are
> > having to undef it... Can you find what the original definition of it
> > is? And perhaps I should call it PCN_PACKED maybe...
> 
> I'm just taking a guess that's the cause, PACKED is defined in
> /includes/windef.h as the following:
> #ifdef __GNUC__
> #define PACKED __attribute__((packed))
> 
> The line in pcnet.h:
> #define PACKED(A) A __attribute__ ((packed))
> throws a PACKED redefined warning if I leave it as is... 
> 
> So in http://www.northern.ca/projects/qemu/qemu-0.6.0-mingw-pcnet-no_dhcp.zip
> I did:
> #ifdef __GNUC__
>   #ifdef __MINGW32__ //GED
>     #undef PACKED
>   #endif
>   #define PACKED(A) A __attribute__ ((packed))
> #else
>   #error FixMe
> #endif
> 
> which gets rid of the warnings, but may also break the code.

At the start of pci_pcnet_init(), can you enable the printf() statement
which reports the size of the pcnet_RMD and pcnet_TMD structures?

They should both be 16 bytes.

-- 
Antony T Curtis, BSc.                   UNIX, Linux, *BSD, Networking
antony.t.curtis@ntlworld.com            C++, J2EE, Perl, MySQL, Apache
                                        IT Consultancy.