From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33)
	id 1CFdGU-0000wu-9v
	for qemu-devel@nongnu.org; Thu, 07 Oct 2004 14:45:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33)
	id 1CFdGT-0000wX-Ir
	for qemu-devel@nongnu.org; Thu, 07 Oct 2004 14:45:21 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.33) id 1CFdGT-0000wU-Fm
	for qemu-devel@nongnu.org; Thu, 07 Oct 2004 14:45:21 -0400
Received: from [195.130.132.58] (helo=astra.telenet-ops.be)
	by monty-python.gnu.org with esmtp (Exim 4.34) id 1CFd9I-0003zj-0s
	for qemu-devel@nongnu.org; Thu, 07 Oct 2004 14:37:56 -0400
Received: from localhost (localhost.localdomain [127.0.0.1])
	by astra.telenet-ops.be (Postfix) with SMTP id 0B3DF328224
	for <qemu-devel@nongnu.org>; Thu,  7 Oct 2004 20:37:55 +0200 (MEST)
Received: from [192.168.1.2] (d51A51CF1.kabel.telenet.be [81.165.28.241])
	by astra.telenet-ops.be (Postfix) with ESMTP id E48EC32821D
	for <qemu-devel@nongnu.org>; Thu,  7 Oct 2004 20:37:54 +0200 (MEST)
Subject: Re: [Qemu-devel] Linux x86_64 host
From: Bob Deblier <bob.deblier@telenet.be>
In-Reply-To: <Pine.LNX.4.58.0410071811510.29535@wgmdd8.biozentrum.uni-wuerzburg.de>
References: <1097156553.2833.17.camel@orion>
	<Pine.LNX.4.58.0410071700030.29330@wgmdd8.biozentrum.uni-wuerzburg.de>
	<1097162724.2833.31.camel@orion>
	<Pine.LNX.4.58.0410071811510.29535@wgmdd8.biozentrum.uni-wuerzburg.de>
Content-Type: text/plain
Message-Id: <1097174274.2833.41.camel@orion>
Mime-Version: 1.0
Date: Thu, 07 Oct 2004 20:37:54 +0200
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Thu, 2004-10-07 at 18:16, Johannes Schindelin wrote:
> What if you change this line to HOST_AMD64, and just comment the fprintf
> (not the continue)? Of course, you have to change the lines around 1707
> like so:
> 
>                     if (strstart(sym_name, "__op_param", &p)) {
>                         snprintf(name, sizeof(name), "param%s", p);
>                     } else if(sym_name[0]=='.') {
>                         continue;
>                     } else {
>                         snprintf(name, sizeof(name), "(long)(&%s)",
> sym_name);
>                     }
> 
> (the "else if" and the "continue" are important).
> 
> Explanation: sym_names with a "." are most likely local symbols like jump
> labels, which should not even be exported in the object file.

Gotcha - I know excatly what you're referring to now. Still doesn't
completely fix the problem, but hopefully the following patch will:

diff -r1.35 dyngen.c
1541c1541,1542
<                     fprintf(outfile, "extern char %s;\n", sym_name);
---
>                                       if (sym_name[0] != '.')
>                                               fprintf(outfile, "extern
char %s;\n", sym_name);
1707c1708,1710
<                     } else {
---
>                     } else if (sym_name[0] == '.') {
>                                               continue;
>                                       } else {

Sincerely,

Bob Deblier