From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Thomas Huth <thuth@redhat.com>, qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH] hw/arm/xlnx-zynqmp: Remove obsolete 'has_rpu' property
Date: Fri, 19 Feb 2021 15:40:12 +0100 [thread overview]
Message-ID: <10aaa327-e24c-0707-16fb-faa37779fef3@amsat.org> (raw)
In-Reply-To: <CAFEAcA_9nuCvVrhDZo=RQoFngpY=ZrJCOw9NQx9A9GF_BmgN+w@mail.gmail.com>
On 2/19/21 12:58 PM, Peter Maydell wrote:
> On Fri, 19 Feb 2021 at 11:51, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> We hint the 'has_rpu' property is no longer required since commit
>> 6908ec448b4 ("xlnx-zynqmp: Properly support the smp command line
>> option") which was released in QEMU v2.11.0.
>>
>> 3 years later we feel safe enough to remove it without using the
>> usual deprecation policy.
>
> This device is marked user_creatable = false, so the only thing
> that could be setting the property is the board code that creates
> the device. So the property is not user-facing and we can remove it
> without going through the deprecation process.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> (maybe noting the above in the commit message).
OK I'll update, thanks!
prev parent reply other threads:[~2021-02-19 14:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 11:51 [PATCH] hw/arm/xlnx-zynqmp: Remove obsolete 'has_rpu' property Philippe Mathieu-Daudé
2021-02-19 11:58 ` Peter Maydell
2021-02-19 14:40 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10aaa327-e24c-0707-16fb-faa37779fef3@amsat.org \
--to=f4bug@amsat.org \
--cc=alistair@alistair23.me \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).