qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: Eduardo Habkost <eduardo@habkost.net>,
	Libvirt <libvir-list@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH for-7.0] i386: Deprecate the -no-hpet QEMU command line option
Date: Mon, 6 Dec 2021 09:47:58 +0100	[thread overview]
Message-ID: <10bc4172-f6c0-504b-cecb-e7caf9edb074@redhat.com> (raw)
In-Reply-To: <20211206084012.49277-1-thuth@redhat.com>

On 06/12/2021 09.40, Thomas Huth wrote:
> The HPET setting has been turned into a machine property a while ago
> already, so we should finally do the next step and deprecate the
> legacy CLI option, too.
> While we're at it, add a proper help text for the machine property, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   docs/about/deprecated.rst | 6 ++++++
>   hw/i386/pc.c              | 2 ++
>   qemu-options.hx           | 2 +-
>   softmmu/vl.c              | 1 +
>   4 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index 5693abb663..1dfe69aa6a 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -198,6 +198,12 @@ form is preferred.
>   Using ``-drive if=none`` to configure the OTP device of the sifive_u
>   RISC-V machine is deprecated. Use ``-drive if=pflash`` instead.
>   
> +``-no-hpet`` (since 7.0)
> +''''''''''''''''''''''''
> +
> +The HPET setting has been turned into a machine property.
> +Use ``-machine hpet=off`` instead.
[...]

Forgot to CC: the libvirt folks, doing so now.

Seems like libvirt is still using -no-hpet in some few spots, so I guess 
these would need to be changed first, before we could finally remove this 
option in QEMU?

  Thomas



  reply	other threads:[~2021-12-06  8:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-06  8:40 [PATCH for-7.0] i386: Deprecate the -no-hpet QEMU command line option Thomas Huth
2021-12-06  8:47 ` Thomas Huth [this message]
2021-12-06  8:57   ` Peter Krempa
2021-12-06  9:02     ` Thomas Huth
2021-12-06  9:19       ` Peter Krempa
2021-12-06  9:44         ` Thomas Huth
2021-12-06  9:56           ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10bc4172-f6c0-504b-cecb-e7caf9edb074@redhat.com \
    --to=thuth@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=libvir-list@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).