From: Jason Wang <jasowang@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org,
Dmitry Fleytman <dmitry.fleytman@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] net: Move the toeplitz functions from checksum.h to net_rx_pkt.c
Date: Tue, 27 Feb 2018 15:55:32 +0800 [thread overview]
Message-ID: <10bec09b-eead-8a2a-aff3-f42e914da451@redhat.com> (raw)
In-Reply-To: <1519290253-23854-1-git-send-email-thuth@redhat.com>
On 2018年02月22日 17:04, Thomas Huth wrote:
> The functions are only used in this single .c file, so there is
> no need to put all this code in a header that is included from
> multiple places.
>
> Signed-off-by: Thomas Huth<thuth@redhat.com>
> ---
> hw/net/net_rx_pkt.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
> include/net/checksum.h | 44 --------------------------------------------
> 2 files changed, 44 insertions(+), 44 deletions(-)
Hi Thomas,
We have plan to implement RSS for virtio-net, so it looks like we'd
better keep it in the header.
Thanks
next prev parent reply other threads:[~2018-02-27 7:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 9:04 [Qemu-devel] [PATCH] net: Move the toeplitz functions from checksum.h to net_rx_pkt.c Thomas Huth
2018-02-27 7:55 ` Jason Wang [this message]
2018-02-27 8:03 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10bec09b-eead-8a2a-aff3-f42e914da451@redhat.com \
--to=jasowang@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).